Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/converse messages #144

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Refactor/converse messages #144

merged 5 commits into from
Oct 13, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Oct 10, 2023 •
edited
Loading

Companion PR to OpenVoiceOS/ovos-core#371

@emphasize emphasize mentioned this pull request Oct 10, 2023
Merged
@JarbasAl JarbasAl added enhancement New feature or request refactor code improvements with no functional changes labels Oct 13, 2023
@JarbasAl JarbasAl merged commit c0c9c6e into OpenVoiceOS:dev Oct 13, 2023
7 checks passed
@JarbasAl
Copy link
Member

note for other devs:

  • tests removed because they are duplicated from ovos-core
  • seems like a breaking change, but this api was never stable and introduced in this alpha release cycle
  • within same alpha version there is no promise of backwards compat

This was referenced Dec 29, 2023
Closed
Merged
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarbasAl JarbasAl JarbasAl left review comments

Assignees
No one assigned
Labels
enhancement New feature or request refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emphasize @JarbasAl