feat/track_speaking+recording_per_session #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep track of is_speaking and is_recording per session brings back `is_speaking` and `wait_while_speaking` per Session, allowing HiveMind integration
mikejgray
reviewed
May 1, 2024
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
May 1, 2024
feat/wait_while_speaking extract into helper method + add wait flag to play_audio
JarbasAl
added a commit
to JarbasHiveMind/ZZZ-HiveMind-core
that referenced
this pull request
May 1, 2024
companion to OpenVoiceOS/ovos-bus-client#93 by default allows voice sats to report if they are recording/playing audio, exposing that info to Session avoids the need of configuring devices individually by default ``` $hivemind-core allow-msg "recognizer_loop:record_begin" $hivemind-core allow-msg "recognizer_loop:record_end" $hivemind-core allow-msg "recognizer_loop:audio_output_start" $hivemind-core allow-msg "recognizer_loop:audio_output_end" ```
JarbasAl
added a commit
to JarbasHiveMind/ZZZ-HiveMind-core
that referenced
this pull request
May 2, 2024
companion to OpenVoiceOS/ovos-bus-client#93 by default allows voice sats to report if they are recording/playing audio, exposing that info to Session avoids the need of configuring devices individually by default ``` $hivemind-core allow-msg "recognizer_loop:record_begin" $hivemind-core allow-msg "recognizer_loop:record_end" $hivemind-core allow-msg "recognizer_loop:audio_output_start" $hivemind-core allow-msg "recognizer_loop:audio_output_end" ```
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
May 7, 2024
* rebase on OpenVoiceOS/ovos-bus-client#93 feat/wait_while_speaking extract into helper method + add wait flag to play_audio * Update requirements.txt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings back
is_speakingandwait_while_speakingper Sessionenables OpenVoiceOS/OVOS-workshop#190
skill/plugin side we can now do
enables HiveMind integration, HiveMind should whitelist the output_start/end messages for voice sats to work
https://github.com/JarbasHiveMind/HiveMind-core/pull/85 avoids the need to configure devices individually HM side