Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/wait_while_speaking #190

Merged
merged 2 commits into from
May 7, 2024
Merged

feat/wait_while_speaking #190

merged 2 commits into from
May 7, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Mar 13, 2024

make wait kwarg session aware + add wait flag to play_audio

needs OpenVoiceOS/ovos-bus-client#93

@JarbasAl JarbasAl added the enhancement New feature or request label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@18f4e11). Click here to learn what that means.

Files Patch % Lines
ovos_workshop/skills/ovos.py 18.75% 13 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #190   +/-   ##
======================================
  Coverage       ?   53.48%           
======================================
  Files          ?       36           
  Lines          ?     3818           
  Branches       ?        0           
======================================
  Hits           ?     2042           
  Misses         ?     1776           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review May 1, 2024 21:50
@JarbasAl JarbasAl requested a review from goldyfruit May 1, 2024 21:51
feat/wait_while_speaking

extract into helper method + add wait flag to play_audio
@JarbasAl JarbasAl force-pushed the feat/wait_while_speaking branch from 925c71f to e84f78b Compare May 1, 2024 22:07
@JarbasAl JarbasAl merged commit af2cc2a into dev May 7, 2024
9 checks passed
@JarbasAl JarbasAl deleted the feat/wait_while_speaking branch May 7, 2024 16:30
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant