Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/logs #213

Merged
merged 1 commit into from
Jun 20, 2024
Merged

refactor/logs #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ovos_workshop/skills/fallback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from ovos_utils.metrics import Stopwatch
from ovos_utils.skills import get_non_properties

from ovos_workshop.decorators.killable import killable_event
from ovos_workshop.decorators.killable import AbortEvent, killable_event
from ovos_workshop.decorators.compat import backwards_compat
from ovos_workshop.permissions import FallbackMode
from ovos_workshop.skills.ovos import OVOSSkill
Expand Down Expand Up @@ -382,12 +382,14 @@ def _handle_fallback_request(self, message: Message):
key=operator.itemgetter(0))
for prio, handler in sorted_handlers:
try:
handler_name = get_handler_name(handler)
# call handler, conditionally activating the skill
status = self._conditional_activate(handler, message=message)
if status:
# indicate completion
handler_name = get_handler_name(handler)
break
except AbortEvent:
LOG.debug(f"fallback handler '{handler_name}' killed because it timed out!")
except Exception:
LOG.exception('Exception in fallback.')
else:
Expand Down
Loading