Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/logs #213

Merged
merged 1 commit into from
Jun 20, 2024
Merged

refactor/logs #213

merged 1 commit into from
Jun 20, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jun 20, 2024

better logs when fallback is killed, so the AbortEvent doesnt scare users


2024-06-20 22:04:41.292 - skills - ovos_core.intent_services.fallback_service:handle_ack:98 - INFO - ovos-skill-slow-fallback.openvoiceos will try to handle fallback
2024-06-20 22:04:41.336 - skills - ovos_core.intent_services.fallback_service:handle_ack:98 - INFO - skill-ovos-fallback-unknown.openvoiceos will try to handle fallback
2024-06-20 22:04:51.351 - skills - ovos_core.intent_services.fallback_service:attempt_fallback:156 - WARNING - ovos-skill-slow-fallback.openvoiceos took too long to answer, increasing "max_skill_runtime" in mycroft.conf might help alleviate this issue
2024-06-20 22:04:51.368 - skills - ovos_core.intent_services:handle_utterance:396 - DEBUG - intent matching took: 10.171107530593872
2024-06-20 22:04:51.373 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session
2024-06-20 22:04:51.374 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session
2024-06-20 22:04:51.374 - skills - ovos_workshop.skills.fallback:_handle_fallback_request:392 - DEBUG - fallback handler 'SlowFallbackSkill.handle_fallback' killed because it timed out!

relates to OpenVoiceOS/ovos-core#389

better logs when fallback is killed, so the AbortEvent doesnt scare users

```

2024-06-20 22:04:41.292 - skills - ovos_core.intent_services.fallback_service:handle_ack:98 - INFO - ovos-skill-slow-fallback.openvoiceos will try to handle fallback
2024-06-20 22:04:41.336 - skills - ovos_core.intent_services.fallback_service:handle_ack:98 - INFO - skill-ovos-fallback-unknown.openvoiceos will try to handle fallback
2024-06-20 22:04:51.351 - skills - ovos_core.intent_services.fallback_service:attempt_fallback:156 - WARNING - ovos-skill-slow-fallback.openvoiceos took too long to answer, increasing "max_skill_runtime" in mycroft.conf might help alleviate this issue
2024-06-20 22:04:51.368 - skills - ovos_core.intent_services:handle_utterance:396 - DEBUG - intent matching took: 10.171107530593872
2024-06-20 22:04:51.373 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session
2024-06-20 22:04:51.374 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session
2024-06-20 22:04:51.374 - skills - ovos_workshop.skills.fallback:_handle_fallback_request:392 - DEBUG - fallback handler 'SlowFallbackSkill.handle_fallback' killed because it timed out!
```
@JarbasAl JarbasAl added the refactor code improvements with no functional changes label Jun 20, 2024
@JarbasAl JarbasAl merged commit 31ad892 into dev Jun 20, 2024
8 checks passed
@JarbasAl JarbasAl deleted the refactor/logs branch June 20, 2024 21:09
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant