Update imports to support ovos-utils~=0.0.x with compat. warnings #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
reviewed
May 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #201 +/- ##
======================================
Coverage ? 52.38%
======================================
Files ? 36
Lines ? 3917
Branches ? 0
======================================
Hits ? 2052
Misses ? 1865
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
reviewed
May 6, 2024
NeonDaniel
commented
May 6, 2024
NeonDaniel
force-pushed
the
PATCH_OvosUtilsCompat
branch
from
f4fd6bd to
e736282
Compare
JarbasAl
requested changes
May 7, 2024
JarbasAl
reviewed
May 7, 2024
JarbasAl
approved these changes
May 8, 2024
NeonDaniel
added a commit
to OpenVoiceOS/ovos-plugin-manager
that referenced
this pull request
May 8, 2024
JarbasAl
pushed a commit
to OpenVoiceOS/ovos-plugin-manager
that referenced
this pull request
May 9, 2024
* Update for ovos-utils 0.0.X compat. Related to OpenVoiceOS/OVOS-workshop#201 * Add ovos-utils alpha dependency to test.txt * More import refactoring to allow ovos-utils<0.1 * Refactor to include backwards-compat imports * Refactor for ovos-utils 0.0.X compat * Wrap unused imports for compat. --------- Co-authored-by: Daniel McKnight <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds re-declaration of methods/classes that cannot be imported
Closes #200