Update for ovos-utils 0.0.X compat. #224
Conversation
|
just for completeness, known affected plugins are https://github.com/OpenVoiceOS/ovos-vlc-plugin https://github.com/OpenVoiceOS/ovos-audio-plugin-simple I'd also like some (human) tests with ovos-audio + these plugins |
Would it be easier then to just revert to the try/except imports rather than adding these new changes? This seems like a lot of refactoring/testing for a deprecated module |
looking at the plugins they are importing from https://github.com/OpenVoiceOS/ovos-ocp-audio-plugin/blob/dev/ovos_plugin_common_play/ocp/base.py , so i guess this is mostly irrelevant, as those are re-implemented there up to you, as long as manually you test ovos-audio works with those 2 plugins + this branch it's all good looking at the code in this package in isolation, these changes seem the correct thing to do that covers more use cases, but in practice i dont expect any impact at all looking at all components as a whole dont think any plugins in the wild exist using this class directly at all |
NeonDaniel
force-pushed
the
FIX_OvosUtils0.0.xCompat
branch
from
fab759f to
7c1f7b1
Compare
NeonDaniel
force-pushed
the
FIX_OvosUtils0.0.xCompat
branch
from
7c1f7b1 to
86ee25b
Compare
|
Validated by stopping the GUI and allowing OCP to select the Audio Service for playback |
* Add test case to validate backend plugin load * Update dependency to test OpenVoiceOS/ovos-plugin-manager#224 * Update OPM dependency to pip spec --------- Co-authored-by: Daniel McKnight <[email protected]>
Similar to OpenVoiceOS/OVOS-workshop#201