-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Meeting Info: change count structure levels #4450
Merged
Elblinator
merged 6 commits into
OpenSlides:main
from
reiterl:4271-change-count-speakers
Dec 17, 2024
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6eb968c
Update Meeting Info: change count structure levels
reiterl 94c9425
Add 'Without structure level' for parliamentMode
reiterl e4995da
Rename map_for_aggregation, update subscription
reiterl 8336291
Update meeting info subscription, small fix
reiterl 4badf59
Merge branch 'main' into 4271-change-count-speakers
reiterl c37ed3a
Add two fixes to non-parliament mode (sub, empty strlvl)
reiterl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
import { Component, OnInit } from '@angular/core'; | ||
import { TranslateService } from '@ngx-translate/core'; | ||
import { filter, firstValueFrom, map } from 'rxjs'; | ||
import { FULL_FIELDSET } from 'src/app/domain/fieldsets/misc'; | ||
import { OrganizationRepositoryService } from 'src/app/gateways/repositories/organization-repository.service'; | ||
import { BaseMeetingComponent } from 'src/app/site/pages/meetings/base/base-meeting.component'; | ||
import { ViewMeeting } from 'src/app/site/pages/meetings/view-models/view-meeting'; | ||
|
@@ -49,14 +50,39 @@ export class MeetingInfoComponent extends BaseMeetingComponent implements OnInit | |
} | ||
] | ||
}, | ||
{ | ||
idField: `speaker_ids`, | ||
fieldset: [`id`, `begin_time`, `end_time`], | ||
follow: [ | ||
{ | ||
idField: `structure_level_list_of_speakers_id`, | ||
fieldset: FULL_FIELDSET | ||
} | ||
] | ||
}, | ||
{ | ||
idField: `list_of_speakers_ids`, | ||
fieldset: [], | ||
follow: [ | ||
{ | ||
idField: `speaker_ids`, | ||
fieldset: [`begin_time`, `end_time`, `point_of_order`], | ||
follow: [`meeting_user_id`] | ||
follow: [ | ||
{ | ||
idField: `meeting_user_id`, | ||
fieldset: FULL_FIELDSET | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you need everything here? This can be extremely much. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I only need user_id as far as I know. |
||
}, | ||
{ | ||
idField: `structure_level_list_of_speakers_id`, | ||
fieldset: FULL_FIELDSET, | ||
follow: [ | ||
{ | ||
idField: `structure_level_id`, | ||
fieldset: [`name`] | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done