-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Meeting Info: change count structure levels #4450
Update Meeting Info: change count structure levels #4450
Conversation
Add a dummy structure level in parliament mode, too. |
@@ -58,48 +63,43 @@ export class ListOfSpeakersControllerService extends BaseController<ViewListOfSp | |||
* @returns A list, which entries are `SpeakingTimeStructureLevelObject`. | |||
*/ | |||
public getSpeakingTimeStructureLevelRelation(): SpeakingTimeStructureLevelObject[] { | |||
let listSpeakingTimeStructureLevel: SpeakingTimeStructureLevelObject[] = []; | |||
const map_for_aggregation = new Map<Id, SpeakingTimeStructureLevelObject>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const map_for_aggregation = new Map<Id, SpeakingTimeStructureLevelObject>(); | |
const mapForAggregation = new Map<Id, SpeakingTimeStructureLevelObject>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
follow: [ | ||
{ | ||
idField: `meeting_user_id`, | ||
fieldset: FULL_FIELDSET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need everything here? This can be extremely much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only need user_id as far as I know.
I tried to fix the problems, but run into a speaker.user is no set error in non-parliament mode, I need to debug that. |
The autoupdate service needs some time to return the meeting_info_X subscription result. In this interval speaker.user is undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only non-parlamentarian modus:
- If the structure level are not preloaded somewhere else the table shows "no data"
(Repo: let someone speak, navigate to "Count completed requests to speak" > you see data, reload page > "no data" is shown) - please show the users who have no structure level in the table (same appearance as in the parlamentarian-modus but only people with no structure level at all are counted
Styling:
in parlamentarian-modus and non-parlamentarian-modus make "Without Structure Level" the font-style: italic;
Sorting:
Please sort the structure level alphabetically
With the exception of "Without Structure Level" please put that item at the end of the list
I don't like this issue anymore. Deassigned. |
I have written a fix for the subscription problem and non-structure level case for non-parliament mode. |
Resolve #4271
In non-parliament mode add the time to all structure levels of a speaker user.