Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Meeting Info: change count structure levels #4450

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Dec 4, 2024

Resolve #4271

In non-parliament mode add the time to all structure levels of a speaker user.

@reiterl reiterl added the bug label Dec 4, 2024
@reiterl reiterl added this to the 4.2 milestone Dec 4, 2024
@reiterl
Copy link
Member Author

reiterl commented Dec 5, 2024

Add a dummy structure level in parliament mode, too.

@@ -58,48 +63,43 @@ export class ListOfSpeakersControllerService extends BaseController<ViewListOfSp
* @returns A list, which entries are `SpeakingTimeStructureLevelObject`.
*/
public getSpeakingTimeStructureLevelRelation(): SpeakingTimeStructureLevelObject[] {
let listSpeakingTimeStructureLevel: SpeakingTimeStructureLevelObject[] = [];
const map_for_aggregation = new Map<Id, SpeakingTimeStructureLevelObject>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const map_for_aggregation = new Map<Id, SpeakingTimeStructureLevelObject>();
const mapForAggregation = new Map<Id, SpeakingTimeStructureLevelObject>();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

follow: [
{
idField: `meeting_user_id`,
fieldset: FULL_FIELDSET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need everything here? This can be extremely much.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only need user_id as far as I know.

@bastianjoel bastianjoel assigned reiterl and unassigned bastianjoel and Elblinator Dec 9, 2024
@reiterl
Copy link
Member Author

reiterl commented Dec 9, 2024

I tried to fix the problems, but run into a speaker.user is no set error in non-parliament mode, I need to debug that.

The autoupdate service needs some time to return the meeting_info_X
subscription result. In this interval speaker.user is undefined.
@reiterl reiterl requested a review from bastianjoel December 9, 2024 12:45
@reiterl reiterl assigned bastianjoel and Elblinator and unassigned reiterl Dec 9, 2024
@bastianjoel bastianjoel removed their assignment Dec 9, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only non-parlamentarian modus:

  1. If the structure level are not preloaded somewhere else the table shows "no data"
    (Repo: let someone speak, navigate to "Count completed requests to speak" > you see data, reload page > "no data" is shown)
  2. please show the users who have no structure level in the table (same appearance as in the parlamentarian-modus but only people with no structure level at all are counted

Styling:
in parlamentarian-modus and non-parlamentarian-modus make "Without Structure Level" the font-style: italic;

Sorting:
Please sort the structure level alphabetically
With the exception of "Without Structure Level" please put that item at the end of the list

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Dec 12, 2024
@Elblinator Elblinator modified the milestones: 4.2, 4.3 Dec 13, 2024
@reiterl
Copy link
Member Author

reiterl commented Dec 16, 2024

I don't like this issue anymore. Deassigned.

@reiterl reiterl removed their assignment Dec 16, 2024
@reiterl
Copy link
Member Author

reiterl commented Dec 16, 2024

I have written a fix for the subscription problem and non-structure level case for non-parliament mode.
I think for the styling and the sorting a new issue should be opened.

@bastianjoel bastianjoel removed their assignment Dec 16, 2024
@Elblinator Elblinator merged commit 03f93ca into OpenSlides:main Dec 17, 2024
4 checks passed
@reiterl reiterl deleted the 4271-change-count-speakers branch December 17, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to speak list is empty
3 participants