Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of linter warnings #3644

Merged
merged 5 commits into from
May 14, 2024
Merged

Cleanup of linter warnings #3644

merged 5 commits into from
May 14, 2024

Conversation

Elblinator
Copy link
Member

part of #3442

@Elblinator Elblinator added this to the 4.2 milestone May 3, 2024
@Elblinator Elblinator marked this pull request as ready for review May 3, 2024 14:20
@luisa-beerboom luisa-beerboom removed their assignment May 6, 2024
reiterl
reiterl reviewed May 6, 2024
View reviewed changes
Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes the remove of meetingSettingService . Shouldn't this be done in a separate pr?

Loki Tobias Elble added 2 commits May 6, 2024 13:41
@Elblinator
Copy link
Member Author

You're right, I committed the wrong commits. I reverted them now.
Good catch :)

@bastianjoel bastianjoel merged commit 53fa7e0 into OpenSlides:main May 14, 2024
2 checks passed
@Elblinator Elblinator deleted the 3442-linter-warning-3 branch May 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiterl reiterl reiterl left review comments

@luisa-beerboom luisa-beerboom luisa-beerboom approved these changes

@bastianjoel bastianjoel bastianjoel approved these changes

Assignees

@bastianjoel bastianjoel

Labels
clean up
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Elblinator @bastianjoel @reiterl @luisa-beerboom