Cleanup linter warnings (#3644)

client/src/app/gateways/actions/action.ts

@@ -58,4 +58,4 @@ export class Action<T = void> {
     }
 }
 
-export const createEmptyAction = () => new Action(async () => []);
+export const createEmptyAction = (): Action<any> => new Action(async () => []);

client/src/app/gateways/base-icc-gateway.service.ts

@@ -72,7 +72,7 @@ export abstract class BaseICCGatewayService<ICCResponseType> {
             msgSub.unsubscribe();
             onClosedSub.unsubscribe();
         });
-        this.connectionClosingFn = () => {
+        this.connectionClosingFn = (): void => {
             onReastartSub.unsubscribe();
             msgSub.unsubscribe();
             onClosedSub.unsubscribe();

client/src/app/gateways/export/pdf-document.service/pdf-document.service.ts

@@ -202,7 +202,7 @@ class PdfCreator {
         });
 
         // the result of the worker
-        this._pdfWorker.onmessage = ({ data }) => {
+        this._pdfWorker.onmessage = ({ data }): void => {
             // if the worker returns a numbers, is always the progress
             if (typeof data === `number`) {
                 // update progress

client/src/app/gateways/export/pdf-document.service/pdf-worker.worker.ts

@@ -4,15 +4,15 @@ import * as pdfMake from 'pdfmake/build/pdfmake';
 
 const osTableLayout = {
     switchColorTableLayout: {
-        hLineWidth: (rowIndex: any) => rowIndex === 1,
-        vLineWidth: () => 0,
-        fillColor: (rowIndex: any) => (rowIndex % 2 === 0 ? `#EEEEEE` : null)
+        hLineWidth: (rowIndex: any): boolean => rowIndex === 1,
+        vLineWidth: (): number => 0,
+        fillColor: (rowIndex: any): string => (rowIndex % 2 === 0 ? `#EEEEEE` : null)
     },
     metaboxLayout: {
-        fillColor: () => `#dddddd`,
-        hLineWidth: (i: any, node: any) => (i === 0 || i === node.table.body.length ? 0 : 0.5),
-        vLineWidth: () => 0,
-        hLineColor: () => `white`
+        fillColor: (): string => `#dddddd`,
+        hLineWidth: (i: any, node: any): 0 | 0.5 => (i === 0 || i === node.table.body.length ? 0 : 0.5),
+        vLineWidth: (): number => 0,
+        hLineColor: (): string => `white`
     }
 };
 

client/src/app/gateways/presenter/history-presenter.service.ts

@@ -48,7 +48,7 @@ interface HistoryPresenterResponse {
 
 const HISTORY_ENDPOINT = `/system/autoupdate/history_information`;
 
-const getUniqueItems = (positions: Position[]) => {
+const getUniqueItems = (positions: Position[]): Position[] => {
     const positionMap: { [positionNumber: number]: Position } = {};
     for (const position of positions) {
         positionMap[position.position] = position;

client/src/app/gateways/repositories/agenda/agenda-item-repository.service.ts

@@ -25,7 +25,7 @@ export class AgendaItemRepositoryService extends BaseMeetingRelatedRepository<Vi
         this.setSortFunction((a, b) => a.tree_weight - b.tree_weight); // leave the sorting as it is
     }
 
-    public getVerboseName = (plural = false) => this.translate.instant(plural ? `Items` : `Item`);
+    public getVerboseName = (plural = false): string => this.translate.instant(plural ? `Items` : `Item`);
 
     private getAgendaTitle(viewAgendaItem: ViewAgendaItem): AgendaListTitle {
         if (viewAgendaItem.content_object) {
@@ -36,9 +36,9 @@ export class AgendaItemRepositoryService extends BaseMeetingRelatedRepository<Vi
         return { title: `-` }; // Default: Clarify which is the default
     }
 
-    public getTitle = (viewAgendaItem: ViewAgendaItem) => this.getAgendaTitle(viewAgendaItem).title;
+    public getTitle = (viewAgendaItem: ViewAgendaItem): string => this.getAgendaTitle(viewAgendaItem).title;
 
-    public getSubtitle = (viewAgendaItem: ViewAgendaItem) => this.getAgendaTitle(viewAgendaItem).subtitle;
+    public getSubtitle = (viewAgendaItem: ViewAgendaItem): string => this.getAgendaTitle(viewAgendaItem).subtitle;
 
     public getItemNumberPrefix(viewModel: HasAgendaItem): string {
         return viewModel.agenda_item && viewModel.agenda_item.item_number
@@ -128,7 +128,7 @@ export class AgendaItemRepositoryService extends BaseMeetingRelatedRepository<Vi
      */
     protected override createViewModel(model: AgendaItem): ViewAgendaItem {
         const viewModel = super.createViewModel(model);
-        viewModel.getSubtitle = () => this.getSubtitle(viewModel) as string;
+        viewModel.getSubtitle = (): string => this.getSubtitle(viewModel) as string;
         return viewModel;
     }
 

client/src/app/gateways/repositories/assignments/assignment-candidate-repository.service/assignment-candidate-repository.service.ts

@@ -21,10 +21,10 @@ export class AssignmentCandidateRepositoryService extends BaseMeetingRelatedRepo
         super(repositoryServiceCollector, AssignmentCandidate);
     }
 
-    public getTitle = (viewAssignmentCandidate: ViewAssignmentCandidate) =>
+    public getTitle = (viewAssignmentCandidate: ViewAssignmentCandidate): string =>
         viewAssignmentCandidate.user?.getTitle() ?? UnknownUserLabel;
 
-    public getVerboseName = (plural = false) => this.translate.instant(plural ? `Candidates` : `Candidate`);
+    public getVerboseName = (plural = false): string => this.translate.instant(plural ? `Candidates` : `Candidate`);
 
     public async create(assignment: Identifiable, meetingUserId: Id): Promise<Identifiable> {
         const payload = {

client/src/app/gateways/repositories/assignments/assignment-repository.service/assignment-repository.service.ts

@@ -58,9 +58,9 @@ export class AssignmentRepositoryService extends BaseAgendaItemAndListOfSpeakers
         return this.sendBulkActionToBackend(AssignmentAction.DELETE, payload);
     }
 
-    public getTitle = (viewAssignment: ViewAssignment) => viewAssignment.title;
+    public getTitle = (viewAssignment: ViewAssignment): string => viewAssignment.title;
 
-    public getVerboseName = (plural = false) => this.translate.instant(plural ? `Elections` : `Election`);
+    public getVerboseName = (plural = false): string => this.translate.instant(plural ? `Elections` : `Election`);
 
     private getPartialPayload(model: Partial<ViewAssignment>): any {
         return {

client/src/app/gateways/repositories/base-agenda-item-and-list-of-speakers-content-object-repository.ts

@@ -37,16 +37,16 @@ export abstract class BaseAgendaItemAndListOfSpeakersContentObjectRepository<
         return numberPrefix + this.getTitle(viewModel);
     }
 
-    public getListOfSpeakersTitle = (viewModel: V) => this.getAgendaListTitle(viewModel).title;
+    public getListOfSpeakersTitle = (viewModel: V): string => this.getAgendaListTitle(viewModel).title;
 
-    public getListOfSpeakersSlideTitle = (viewModel: V) => this.getAgendaSlideTitle(viewModel);
+    public getListOfSpeakersSlideTitle = (viewModel: V): string => this.getAgendaSlideTitle(viewModel);
 
     protected override createViewModel(model: M): V {
         const viewModel = super.createViewModel(model);
-        viewModel.getAgendaListTitle = () => this.getAgendaListTitle(viewModel);
-        viewModel.getAgendaSlideTitle = () => this.getAgendaSlideTitle(viewModel);
-        viewModel.getListOfSpeakersTitle = () => this.getListOfSpeakersTitle(viewModel);
-        viewModel.getListOfSpeakersSlideTitle = () => this.getListOfSpeakersSlideTitle(viewModel);
+        viewModel.getAgendaListTitle = (): AgendaListTitle => this.getAgendaListTitle(viewModel);
+        viewModel.getAgendaSlideTitle = (): string => this.getAgendaSlideTitle(viewModel);
+        viewModel.getListOfSpeakersTitle = (): string => this.getListOfSpeakersTitle(viewModel);
+        viewModel.getListOfSpeakersSlideTitle = (): string => this.getListOfSpeakersSlideTitle(viewModel);
         return viewModel;
     }
 }

client/src/app/gateways/repositories/base-agenda-item-content-object-repository.ts

@@ -64,8 +64,8 @@ export abstract class BaseAgendaItemContentObjectRepository<
      */
     protected override createViewModel(model: M): V {
         const viewModel = super.createViewModel(model);
-        viewModel.getAgendaListTitle = () => this.getAgendaListTitle(viewModel);
-        viewModel.getAgendaSlideTitle = () => this.getAgendaSlideTitle(viewModel);
+        viewModel.getAgendaListTitle = (): AgendaListTitle => this.getAgendaListTitle(viewModel);
+        viewModel.getAgendaSlideTitle = (): string => this.getAgendaSlideTitle(viewModel);
         return viewModel;
     }
 }

client/src/app/gateways/repositories/base-list-of-speakers-content-object-repository.ts

@@ -47,8 +47,8 @@ export abstract class BaseListOfSpeakersContentObjectRepository<
      */
     protected override createViewModel(model: M): V {
         const viewModel = super.createViewModel(model);
-        viewModel.getListOfSpeakersTitle = () => this.getListOfSpeakersTitle(viewModel);
-        viewModel.getListOfSpeakersSlideTitle = () => this.getListOfSpeakersSlideTitle(viewModel);
+        viewModel.getListOfSpeakersTitle = (): string => this.getListOfSpeakersTitle(viewModel);
+        viewModel.getListOfSpeakersSlideTitle = (): string => this.getListOfSpeakersSlideTitle(viewModel);
         return viewModel;
     }
 }

client/src/app/gateways/repositories/base-meeting-related-repository.ts

@@ -55,7 +55,8 @@ export abstract class BaseMeetingRelatedRepository<V extends BaseViewModel, M ex
 
     protected override createViewModel(model: M): V {
         const viewModel = super.createViewModel(model);
-        viewModel.getActiveMeetingId = () => this.repositoryMeetingServiceCollector.activeMeetingIdService.meetingId;
+        viewModel.getActiveMeetingId = (): number =>
+            this.repositoryMeetingServiceCollector.activeMeetingIdService.meetingId;
         return viewModel;
     }
 }

client/src/app/gateways/repositories/base-repository.ts

@@ -501,8 +501,8 @@ export abstract class BaseRepository<V extends BaseViewModel, M extends BaseMode
     protected createViewModel(model?: M): V {
         const viewModel = this.createViewModelProxy(model);
 
-        viewModel.getTitle = () => this.getTitle(viewModel);
-        viewModel.getListTitle = () => this.getListTitle(viewModel);
+        viewModel.getTitle = (): string => this.getTitle(viewModel);
+        viewModel.getListTitle = (): string => this.getListTitle(viewModel);
         viewModel.getVerboseName = this.getVerboseName;
 
         this.onCreateViewModel(viewModel);
@@ -588,7 +588,7 @@ export abstract class BaseRepository<V extends BaseViewModel, M extends BaseMode
      */
     private resortAndUpdateForeignBaseKeys(key: string): void {
         const resortAction = {
-            funct: async () => {
+            funct: async (): Promise<void> => {
                 const sortListService = this.sortListServices[key];
                 this.updateForeignBaseKeys(key);
                 await sortListService.hasLoaded;
@@ -612,7 +612,7 @@ export abstract class BaseRepository<V extends BaseViewModel, M extends BaseMode
                 if (this.foreignSortBaseKeys[key][collection].some(key => keys.includes(key))) {
                     this.sortedViewModelLists[key] = await sortListService.sort(this.sortedViewModelLists[key]);
                     const resortAction = {
-                        funct: async () => {
+                        funct: async (): Promise<void> => {
                             this.sortedViewModelLists[key] = await sortListService.sort(this.sortedViewModelLists[key]);
                         },
                         type: PipelineActionType.Resort,

client/src/app/site/pages/meetings/modules/list-of-speakers-content/components/speaking-times/speaking-times.component.ts

@@ -228,7 +228,7 @@ export class SpeakingTimesComponent implements OnDestroy {
         }
     }
 
-    private updateSpeakingTime(speakingTime: ViewStructureLevelListOfSpeakers) {
+    private updateSpeakingTime(speakingTime: ViewStructureLevelListOfSpeakers): void {
         if (speakingTime) {
             if (speakingTime.isInactive) {
                 this.structureLevels.delete(speakingTime.id);

client/src/app/site/pages/meetings/modules/list-of-speakers-content/modules/speaker-user-select-dialog/components/speaker-user-select-dialog/speaker-user-select-dialog.component.ts

@@ -25,7 +25,7 @@ export class SpeakerUserSelectDialogComponent {
         public userRepo: UserRepositoryService
     ) {}
 
-    public setCurrentUser(selection: UserSelectionData) {
+    public setCurrentUser(selection: UserSelectionData): void {
         if (selection.userId) {
             const meeting_user = this.userRepo
                 .getViewModel(selection.userId)

client/src/app/site/pages/meetings/modules/meetings-component-collector/projectable-list/components/projectable-list/projectable-list.component.ts

@@ -49,12 +49,12 @@ export class ProjectableListComponent<V extends BaseViewModel | BaseProjectableV
     public getSpeakerButtonObject: ((viewModel: V) => BaseViewModel & HasListOfSpeakers) | null = null;
 
     @Input()
-    public override toRestrictFn = (restriction: ColumnRestriction<Permission>) =>
+    public override toRestrictFn = (restriction: ColumnRestriction<Permission>): boolean =>
         !this.operator.hasPerms(restriction.permission);
 
     @Input()
-    public override toHideFn = () => {
-        const columnsToHide = [];
+    public override toHideFn = (): string[] => {
+        let columnsToHide: string[];
 
         // hide the projector columns
         if (this.multiSelect || this.isMobile || !this.allowProjector) {
@@ -90,7 +90,7 @@ export class ProjectableListComponent<V extends BaseViewModel | BaseProjectableV
 
     public readonly permission = Permission;
 
-    public readonly isProjectedFn = (model: BaseProjectableViewModel) =>
+    public readonly isProjectedFn = (model: BaseProjectableViewModel): boolean =>
         this.service.isProjectedOnReferenceProjector(model);
 
     public constructor(

client/src/app/site/pages/meetings/modules/participant-search-selector/components/participant-search-selector/participant-search-selector.component.ts

@@ -131,7 +131,7 @@ export class ParticipantSearchSelectorComponent extends BaseUiComponent implemen
     /**
      * This function ensures that a selected user is quickly removed from the selection list
      */
-    private removeUserFromSelectorList(userId: number) {
+    private removeUserFromSelectorList(userId: number): void {
         this._filteredUsersSubject.next(
             this._filteredUsersSubject.value.filter(user => {
                 return user.id !== userId;
@@ -143,7 +143,7 @@ export class ParticipantSearchSelectorComponent extends BaseUiComponent implemen
      * Sets the current value of the filteredUsersSubject to an Array that holds exactly every single user,
      * who should be available for selection (i.e. who is not included in nonSelectableUsersSubject.value)
      */
-    private filterUsers() {
+    private filterUsers(): void {
         const notAvailable = this._nonSelectableUserIds;
         const availableUsers = this._users.filter(user => !notAvailable.includes(user.id));
         this._filteredUsersSubject.next(availableUsers);

client/src/app/site/pages/meetings/modules/poll/base/base-poll-vote.component.ts

@@ -112,7 +112,7 @@ export abstract class BasePollVoteComponent<C extends PollContentObject = any> e
         return this.votingService.getVotingProhibitionReasonVerbose(this.poll, user) || ``;
     }
 
-    public getVotingErrorFromName(errorName: string) {
+    public getVotingErrorFromName(errorName: string): string {
         return this.votingService.getVotingProhibitionReasonVerboseFromName(errorName) || ``;
     }
 

client/src/app/site/pages/meetings/modules/poll/components/check-input/check-input.component.ts

@@ -134,7 +134,7 @@ export class CheckInputComponent extends BaseUiComponent implements OnInit, Cont
     /**
      * Helper function to determine which information to give to the parent form
      */
-    private propagateChange = (_: any) => {};
+    private propagateChange = (_: any): void => {};
 
     /**
      * Initially build the form-control.

client/src/app/site/pages/meetings/modules/poll/components/single-option-chart-table/single-option-chart-table.component.ts

@@ -41,7 +41,7 @@ export class SingleOptionChartTableComponent {
         this.cd.markForCheck();
     }
 
-    public get pollService() {
+    public get pollService(): PollService {
         return this._pollService || this.defaultPollService;
     }
 

client/src/app/site/pages/meetings/modules/poll/services/voting.service/voting.service.ts

@@ -105,7 +105,7 @@ export class VotingService {
         }
     }
 
-    public getVotingProhibitionReasonVerboseFromName(reasonName: string) {
+    public getVotingProhibitionReasonVerboseFromName(reasonName: string): string {
         return VotingProhibitionVerbose[VotingProhibition[reasonName]] ?? _(`There is an unknown voting problem.`);
     }
 }

client/src/app/site/pages/meetings/modules/projector/modules/slides/components/poll-slide/components/poll-slide.component.ts

@@ -86,7 +86,7 @@ export class PollSlideComponent extends BaseSlideComponent<PollSlideData> {
     }
 
     private createPollData(data: PollSlideData): PollData {
-        const getContentObjectTitle = () => {
+        const getContentObjectTitle = (): string => {
             if (data.title_information) {
                 modifyAgendaItemNumber(data.title_information);
                 const repo = this.collectionMapperService.getRepository(data.title_information.collection);

client/src/app/site/pages/meetings/pages/agenda/modules/topics/modules/topic-poll/components/topic-poll-detail-content/topic-poll-detail-content.component.ts

@@ -28,7 +28,9 @@ export class TopicPollDetailContentComponent extends BaseUiComponent {
         return this._tableData;
     }
 
-    public get colors() {
+    public get colors(): {
+        backgroundColor: string[];
+    } {
         return this.chartColors[0];
     }
 

client/src/app/site/pages/meetings/pages/agenda/modules/topics/modules/topic-poll/components/topic-poll-dialog/topic-poll-dialog.component.ts

@@ -88,7 +88,7 @@ export class TopicPollDialogComponent extends BasePollDialogComponent implements
         this.optionTypeText = true;
     }
 
-    public ngAfterViewInit() {
+    public ngAfterViewInit(): void {
         if (this.scrollFrame) {
             this.scrollContainer = this.scrollFrame.nativeElement;
             this.itemElements.changes.subscribe(_ => this.onItemElementsChanged());

client/src/app/site/pages/meetings/pages/agenda/modules/topics/modules/topic-poll/components/topic-poll-vote/topic-poll-vote.component.ts

@@ -231,7 +231,7 @@ export class TopicPollVoteComponent extends BasePollVoteComponent<ViewTopic> imp
         this.handleVotingMethodYOrN(maxVotesAmount, tmpVoteRequest, user);
     }
 
-    public handleVotingMethodYOrN(maxVotesAmount: number, tmpVoteRequest: any, user: ViewUser = this.user) {
+    public handleVotingMethodYOrN(maxVotesAmount: number, tmpVoteRequest: any, user: ViewUser = this.user): void {
         // check if you can still vote
         const countedVotes = Object.keys(tmpVoteRequest).filter(key => tmpVoteRequest[key]).length;
         if (countedVotes <= maxVotesAmount) {
@@ -347,7 +347,7 @@ export class TopicPollVoteComponent extends BasePollVoteComponent<ViewTopic> imp
         }
     }
 
-    protected override updatePoll() {
+    protected override updatePoll(): void {
         super.updatePoll();
         this.defineVoteOptions();
     }

client/src/app/site/pages/meetings/pages/agenda/modules/topics/pages/topic-detail/components/topic-detail/topic-detail.component.ts

@@ -77,7 +77,7 @@ export class TopicDetailComponent extends BaseMeetingComponent implements OnInit
 
     private _topicId: Id | null = null;
 
-    public getTitleFn = () => this.topic.getListTitle();
+    public getTitleFn = (): string => this.topic.getListTitle();
 
     public get showNavigateButtons(): boolean {
         return this.enableNavigation && (!!this.previousTopic || !!this.nextTopic);

client/src/app/site/pages/meetings/pages/agenda/pages/agenda-item-list/services/agenda-item-multiselect.service/agenda-item-multiselect.service.ts

@@ -65,14 +65,20 @@ export class AgendaItemMultiselectService {
         }
     }
 
-    private async addTags(agendaItems: ViewAgendaItem[], selectedChoice: ChoiceAnswer<ViewTag>) {
+    private async addTags(
+        agendaItems: ViewAgendaItem[],
+        selectedChoice: ChoiceAnswer<ViewTag>
+    ): Promise<Promise<void>[]> {
         return agendaItems.map(agendaItem => {
             const tagIds = new Set((agendaItem.tag_ids || []).concat(selectedChoice.ids));
             return this.repo.update({ tag_ids: Array.from(tagIds) }, agendaItem);
         });
     }
 
-    private async removeTags(agendaItems: ViewAgendaItem[], selectedChoice: ChoiceAnswer<ViewTag>) {
+    private async removeTags(
+        agendaItems: ViewAgendaItem[],
+        selectedChoice: ChoiceAnswer<ViewTag>
+    ): Promise<Promise<void>[]> {
         return agendaItems.map(agendaItem => {
             const remainingTagIds = new Set(
                 agendaItem.tag_ids.filter(tagId => selectedChoice.ids.indexOf(tagId) === -1)
@@ -81,7 +87,7 @@ export class AgendaItemMultiselectService {
         });
     }
 
-    private async clearTags(agendaItems: ViewAgendaItem[]) {
+    private async clearTags(agendaItems: ViewAgendaItem[]): Promise<Promise<void>[]> {
         return agendaItems.map(agendaItem => this.repo.update({ tag_ids: [] }, agendaItem));
     }
 }

client/src/app/site/pages/meetings/pages/agenda/view-models/view-agenda-item.ts

@@ -33,7 +33,12 @@ export class ViewAgendaItem extends BaseProjectableViewModel<AgendaItem> {
         return type ? type.name : ``;
     }
 
-    public override getProjectorTitle = (_projection: Projection) => {
+    public override getProjectorTitle = (
+        _projection: Projection
+    ): {
+        title: string;
+        subtitle: string;
+    } => {
         const subtitle = this.item.comment || undefined;
         return { title: this.getTitle(), subtitle };
     };