-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend shared worker #3276
Extend shared worker #3276
Conversation
68a387e
to
a9ac43e
Compare
It is not an introduction, it is overwhelmingly done in the client for the simple reason that it is an established convention to put visibility modifiers on everything. The exceptions where it is inconsistent are merely instances that were not caught during the code review. I am not asking you to fix it everywhere right now, I am asking you to fix it in your code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or fix this in another PR
6ece271
to
fa485bc
Compare
fa485bc
to
2e033fe
Compare
@emanuelschuetze @MSoeb @Elblinator @rrenkert Maybe it is not completely obvious by the title and description but this PR includes the longpolling implementation and is finished since last week. The performance tool has a new tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This is a problem with the banner service. Offline mode and out of sync have the same problem. For that reason I think this is totally unrelated to this PR. Please open another issue. |
I created a new Issue |
change requests were moved to another Issue
resolves #3248
resolves #3259
resolves #3401
This PR involves a lot of cleanup in the shared worker. Also tests were added.
TODO: