Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for LinkSet Data related to matching SL behavior #68

Merged
merged 5 commits into from
Dec 3, 2023

Conversation

mdickson
Copy link
Collaborator

Make the events posted for linkset_data go to all scripts in all prims. Similar to attach which is currently handled here. This is yengine only for the moment. XEngine doesn't seem to replicate the all-prims behavior for attach.

Clean up some of the special case handling in LinksetData Write. Writing a key with no value is translated to a delete. We weren't handling that case. Also returned key and value via the script event on a write, we were previously returning a null string for value.

…o all scripts in all prims. Similar to attach which is currently handled here. Clean up some of the special case handling in LinksetData Write. Writing a key with no value is translated to a delete. We weren't handling that case. Also returned key value on a write, we were previously returning a null string.
…perate LinkssetData class. The SOP is one of those things thats already WAY to complex so hopefully this should make maintenance easier. Added code to merge LinksetData stores in order to handle linking 2 SOGs that both have LinksetData. Adjusted serialization handling so the database still stores just the KVPs and the wrapper class is constructed from that. Keeps it compatible with current saved data.
…hared entries. Still need to address shift-copy issues.
…opy. We use that when doing a copy of prims because otherwise the dictionary ends being referenced from both prims on a shift copy, etc. Also used on a merge to create new entries. Fixed some of the accounting code which was incorrectly reporting usage and terminating a copy early on a merge.
@mdickson mdickson self-assigned this Dec 2, 2023
@mdickson mdickson marked this pull request as ready for review December 2, 2023 21:13
@mdickson
Copy link
Collaborator Author

mdickson commented Dec 3, 2023

Liam Hoffen — Today at 11:40 AM
I ran the tests and found success with each of them as well. It looks like everything needed for the breedables and games tables will work with this code in USG. Thank you for your efforts with this project. I'd guess it pulled you sideways from your dev schedule, and I appreciate the work you've put into this. As soon as this goes gridwide, I'll start adding the newer features to Foxtrot's products. After that, I'll be working to bring the InfinityTech game tables to USG. I had written workarounds for LSD in scripts to allow for some features, but the overhead was higher than I'd like and it didn't have the data protection of prim data, as it was all just script data. It'll be nice to remove those hacks from my code.

@mdickson mdickson merged commit be88cb8 into develop Dec 3, 2023
3 checks passed
@mdickson mdickson deleted the feature/linksetdata-bugfix branch December 3, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant