Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Include OneSignalConfig.androidlib meta files #655

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Oct 17, 2023

Description

One Line Summary

Includes .meta files in OneSignalConfig.androidlib to prevent asset from being ignored

Details

Motivation

Fixes compile time errors in Android package - all files in Packages/com.onesignal.unity.android/Editor/OneSignalConfig.androidlib/:

Packages/com.onesignal.unity.android/Editor/OneSignalConfig.androidlib/AndroidManifest.xml has no meta file, but it's in an immutable folder. The asset will be ignored.

Scope

Affects Unity Editor 2021 versions. Reproducible in 2021.3 but I was unable to reproduce in 2022.3.10.

Unity made a change where meta files don't need to be included in plugins for newer versions:
https://forum.unity.com/threads/loadable-plugin-directory-import-behaviour-change-androidlib-bundle-framework-and-plugin.1381113/

It looks like the change does not apply to 2021 because of the compile errors, so it looks like we need to include meta files in our OneSignalConfig.androidlib for 2021 support.

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2021.3.0f1 and 2022.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@shepherd-l shepherd-l merged commit e521d38 into user-model/main Oct 17, 2023
1 check passed
@shepherd-l shepherd-l deleted the fix/androidlibMetaFiles branch October 17, 2023 17:01
jinliu9508 pushed a commit that referenced this pull request Feb 23, 2024
[Fix] Include OneSignalConfig.androidlib meta files
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] Include OneSignalConfig.androidlib meta files
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] Include OneSignalConfig.androidlib meta files
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] Include OneSignalConfig.androidlib meta files
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] Include OneSignalConfig.androidlib meta files
jinliu9508 pushed a commit that referenced this pull request Mar 1, 2024
[Fix] Include OneSignalConfig.androidlib meta files
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] Include OneSignalConfig.androidlib meta files
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] Include OneSignalConfig.androidlib meta files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants