Skip to content

Commit

Permalink
Merge pull request #655 from OneSignal/fix/androidlibMetaFiles
Browse files Browse the repository at this point in the history
[Fix] Include OneSignalConfig.androidlib meta files
  • Loading branch information
shepherd-l authored and jinliu9508 committed Mar 4, 2024
2 parents fd2b8b0 + 0812d8e commit 095ca75
Show file tree
Hide file tree
Showing 22 changed files with 155 additions and 1 deletion.
3 changes: 3 additions & 0 deletions OneSignalExample/Assets/OneSignal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Included meta files in OneSignalConfig.androidlib to prevent asset from being ignored

## [5.0.4]
### Changed
- Updated included Android SDK to [5.0.3](https://github.com/OneSignal/OneSignal-Android-SDK/releases/tag/5.0.3)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ protected override bool _getIsStepCompleted() {

var packagePaths = Directory.GetFiles(_pluginPackagePath, "*", SearchOption.AllDirectories)
.Select(path => path.Remove(0, path.LastIndexOf(_pluginName, StringComparison.InvariantCulture)));
packagePaths = packagePaths.Where(file => !file.EndsWith(".meta"));

var exportPaths = Directory.GetFiles(_pluginExportPath, "*", SearchOption.AllDirectories)
.Select(path => path.Remove(0, path.LastIndexOf(_pluginName, StringComparison.InvariantCulture)));
Expand All @@ -69,8 +70,9 @@ protected override void _runStep() {
MigratePluginToAndroidlib();

var files = Directory.GetFiles(_pluginPackagePath, "*", SearchOption.AllDirectories);
var filteredFiles = files.Where(file => !file.EndsWith(".meta"));

foreach (var file in files) {
foreach (var file in filteredFiles) {
var trimmedPath = file.Remove(0, _pluginPackagePath.Length + 1);
var fileExportPath = Path.Combine(_pluginExportPath, trimmedPath);
var containingPath = fileExportPath.Remove(fileExportPath.LastIndexOf(Path.DirectorySeparatorChar));
Expand Down

0 comments on commit 095ca75

Please sign in to comment.