gp: change from xalan to xsltproc #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
We have been using an outdated version of xalan, which is what is installed using apt in Ubuntu. If you run Fedora, you will receive the latest version. The executable name has changed from "xalan" to "Xalan" and the supported command line arguments are also different. Therefore supporting different versions of xalan across distros can be challenging. One alternative is xsltproc. It looks like it works on both Ubuntu and Fedora, so let's swap out xalan for xsltproc. Signed-off-by: Joakim Bech <[email protected]> Acked-by: Etienne Carriere <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Jerome Forissier <[email protected]> Tested-by: Jerome Forissier <[email protected]> (Ubuntu 20.04) Tested-by: Joakim Bech <[email protected]> (Fedora 41) Tested-by: Joakim Bech <[email protected]> (Ubuntu 22.04)
jbech-linaro
force-pushed
the
gp-package-fix
branch
from
8c6a9ca
to
8a5cd1b
Compare
|
Thanks for quick turnaround and testing. Patch squashed, rebased and tag(s) applied (should be) ready for merge! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using an outdated version of xalan, which is what is installed using apt in Ubuntu. If you run Fedora, you will receive the latest version. The executable name has changed from "xalan" to "Xalan" and the supported command line arguments are also different. Therefore supporting different versions of xalan across distros can be challenging.
One alternative is xsltproc. It looks like it works on both Ubuntu and Fedora, so let's swap out xalan for xsltproc.
Tested-by: Joakim Bech [email protected] (Fedora 41)
Tested-by: Joakim Bech [email protected] (Ubuntu 22.04)