Skip to content

Commit

Permalink
gp: change from xalan to xsltproc
Browse files Browse the repository at this point in the history
We have been using an outdated version of xalan, which is what is
installed using apt in Ubuntu. If you run Fedora, you will receive the
latest version. The executable name has changed from "xalan" to "Xalan"
and the supported command line arguments are also different. Therefore
supporting different versions of xalan across distros can be
challenging.

One alternative is xsltproc. It looks like it works on both Ubuntu and
Fedora, so let's swap out xalan for xsltproc.

Signed-off-by: Joakim Bech <[email protected]>
Acked-by: Etienne Carriere <[email protected]>
Acked-by: Jens Wiklander <[email protected]>
Acked-by: Jerome Forissier <[email protected]>
Tested-by: Jerome Forissier <[email protected]> (Ubuntu 20.04)
Tested-by: Joakim Bech <[email protected]> (Fedora 41)
Tested-by: Joakim Bech <[email protected]> (Ubuntu 22.04)
  • Loading branch information
jbech-linaro authored and jforissier committed Nov 14, 2024
1 parent 695231e commit 55adb62
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions host/xtest/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ if (WITH_GP_TESTS)
macro(__GEN_GP_FILE outfile xmldir name basedir)
add_custom_command(
OUTPUT ${outfile}
COMMAND xalan -in ${basedir}/${name}.xml
-xsl gp/${name}.xsl -out ${outfile}
COMMAND xsltproc -o ${outfile} gp/${name}.xsl
${basedir}/${name}.xml
DEPENDS ${basedir}/${name}.xml gp/${name}.xsl
)
endmacro(__GEN_GP_FILE)
Expand Down

0 comments on commit 55adb62

Please sign in to comment.