Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release of SDK 1.8.2 #805

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Prepare release of SDK 1.8.2 #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d96859b
fields: Remove mandatory constraint on BT-746-Organization (TEDEFO-2789)
bertrand-lorentz Jan 11, 2024
a5f6319
schematrons: Remove ineffective rules for change notices (TEDEFO-2991)
bertrand-lorentz Jul 5, 2023
f02f78e
fields: Remove a rule on BT-743-Lot (TEDEFO-2386)
bertrand-lorentz Jun 29, 2023
9682080
translations: Correct various rule messages (TEDEFO-3012)
bertrand-lorentz Jan 18, 2024
0321974
translations: Add 9 texts for "expression" (TEDEFO-2950)
bertrand-lorentz Dec 20, 2023
a1b7d7f
CHANGELOG: Update for SDK 1.8.2
bertrand-lorentz Jan 22, 2024
d6371f0
translations: Update from SDK 1.9.2
bertrand-lorentz Jan 23, 2024
0f501a4
view-templates: Update from SDK 1.9.2
bertrand-lorentz Jan 23, 2024
91a0320
Set version to 1.8.2 in pom.xml and fields.json
bertrand-lorentz Jan 23, 2024
f32c9f9
view-templates: Correct previous changes
bertrand-lorentz Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
# SDK 1.8.2 Release Notes

This release brings the following corrections in the validation rules, making them more permissive:

* The field "The winner is listed on a regulated market" (BT-746-Organization) is now optional.
* Remove rule BR-BT-00743-0100 that required "Electronic invoicing" (BT-743-Lot) to be set to "required".
* Remove ineffective rules for change notices to improve performance when validating notices with a large number of lots.

This release also includes updated translations and updated notice visualisation templates.

A comprehensive list of changes between SDK 1.8.1 and SDK 1.8.2 can be seen at <https://github.com/OP-TED/eForms-SDK/compare/1.8.1...1.8.2>

You can explore the changes between those versions at <https://docs.ted.europa.eu/eforms-sdk-explorer?base=1.8.1&version=1.8.2>

# SDK 1.8.1 Release Notes

This release brings the following corrections in the validation rules, making them more permissive:
Expand Down
21 changes: 1 addition & 20 deletions fields/fields.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"ublVersion" : "2.3",
"sdkVersion" : "eforms-sdk-1.8.1",
"sdkVersion" : "eforms-sdk-1.8.2",
"metadataDatabase" : {
"version" : "1.8.0",
"createdOn" : "2023-07-21T15:00:00"
Expand Down Expand Up @@ -20983,15 +20983,6 @@
"type" : "flat"
},
"severity" : "ERROR"
},
"assert" : {
"value" : "{ND-Root} ${TRUE}",
"severity" : "ERROR",
"constraints" : [ {
"value" : "{ND-LotTenderingTerms} ${(OPP-070-notice in ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40') and (BT-743-Lot == 'required')) or not(OPP-070-notice in ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40')) or not(BT-743-Lot is present)}",
"severity" : "ERROR",
"message" : "rule|text|BR-BT-00743-0100"
} ]
}
}, {
"id" : "BT-744-Lot",
Expand Down Expand Up @@ -21074,16 +21065,6 @@
"value" : true,
"severity" : "ERROR"
} ]
},
"mandatory" : {
"value" : false,
"severity" : "ERROR",
"constraints" : [ {
"noticeTypes" : [ "25", "26", "27", "28", "29", "30", "31", "32", "33", "34", "35", "36", "37", "T02" ],
"condition" : "{ND-Organization} ${(OPT-200-Organization-Company in OPT-300-Tenderer[OPT-210-Tenderer in OPT-310-Tender[OPT-321-Tender in BT-3202-Contract]]) or (OPT-200-Organization-Company in OPT-301-Tenderer-SubCont[OPT-210-Tenderer in OPT-310-Tender[OPT-321-Tender in BT-3202-Contract]])}",
"value" : true,
"severity" : "ERROR"
} ]
}
}, {
"id" : "BT-747-Lot",
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<groupId>eu.europa.ted.eforms</groupId>
<artifactId>eforms-sdk</artifactId>
<version>1.8.1</version>
<version>1.8.2</version>
<packaging>jar</packaging>

<name>eForms SDK</name>
Expand Down Expand Up @@ -48,7 +48,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.outputTimestamp>2023-10-26T12:38:48Z</project.build.outputTimestamp>
<project.build.outputTimestamp>2024-01-23T10:45:07Z</project.build.outputTimestamp>

<sonatype.server.url>s01.oss.sonatype.org</sonatype.server.url>

Expand Down
14 changes: 0 additions & 14 deletions schematrons/dynamic/validation-stage-4.sch
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion schematrons/dynamic/validation-stage-5.sch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
<assert id="BR-BT-00630-0150" role="ERROR" diagnostics="BT-630_d_-Lot" test="(cbc:EndDate/xs:date(text()) > ../../../../../../../cbc:IssueDate/xs:date(text())) or not((cbc:EndDate) and (../../../../../../../cbc:IssueDate))">rule|text|BR-BT-00630-0150</assert>
</rule>
<rule context="/*/cac:ProcurementProjectLot[cbc:ID/@schemeName='Lot']/cac:TenderingTerms">
<assert id="BR-BT-00743-0100" role="ERROR" diagnostics="BT-743-Lot" test="(../../ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:NoticeSubType/cbc:SubTypeCode/normalize-space(text()) = ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40') and (cac:ContractExecutionRequirement/cbc:ExecutionRequirementCode[@listName='einvoicing']/normalize-space(text()) = 'required')) or not(../../ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:NoticeSubType/cbc:SubTypeCode/normalize-space(text()) = ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40')) or not(cac:ContractExecutionRequirement/cbc:ExecutionRequirementCode[@listName='einvoicing'])">rule|text|BR-BT-00743-0100</assert>
<assert id="BR-OPT-00301-1400" role="ERROR" diagnostics="OPT-301-Lot-AddInfo" test="(((cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:Company/cac:PartyIdentification/cbc:ID/normalize-space(text())) or (cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:TouchPoint/cac:PartyIdentification/cbc:ID/normalize-space(text())))) or not(cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID)">rule|text|BR-OPT-00301-1400</assert>
<assert id="BR-OPT-00301-1402" role="ERROR" diagnostics="OPT-301-Lot-DocProvider" test="(((cac:DocumentProviderParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:Company/cac:PartyIdentification/cbc:ID/normalize-space(text())) or (cac:DocumentProviderParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:TouchPoint/cac:PartyIdentification/cbc:ID/normalize-space(text())))) or not(cac:DocumentProviderParty/cac:PartyIdentification/cbc:ID)">rule|text|BR-OPT-00301-1402</assert>
<assert id="BR-OPT-00301-1420" role="ERROR" diagnostics="OPT-301-Lot-TenderEval" test="(((cac:TenderEvaluationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:Company/cac:PartyIdentification/cbc:ID/normalize-space(text())) or (cac:TenderEvaluationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:TouchPoint/cac:PartyIdentification/cbc:ID/normalize-space(text())))) or not(cac:TenderEvaluationParty/cac:PartyIdentification/cbc:ID)">rule|text|BR-OPT-00301-1420</assert>
Expand Down
Loading