Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] portal_partner_data_no_edit: Migration to 15.0 #1393

Merged
merged 7 commits into from
Nov 8, 2022
Merged

[15.0][MIG] portal_partner_data_no_edit: Migration to 15.0 #1393

merged 7 commits into from
Nov 8, 2022

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT36489

supersed of #1343

please @sergio-teruel @chienandalu review this

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-portal_partner_data_no_edit branch from d2d0948 to 2dec447 Compare November 7, 2022 16:58
@pedrobaeza pedrobaeza mentioned this pull request Nov 7, 2022
Closed
@pedrobaeza
Copy link
Member

/ocabot migration portal_partner_data_no_edit

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 7, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 7, 2022
Open
68 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#1153) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1343.
Perhaps you should check that there is no duplicate work.
CC : @JoelZilli

@CarlosRoca13
Copy link
Contributor Author

I have kept @JoelZilli's migration commit and fixed the issue so that the module works normally

@CarlosRoca13
Copy link
Contributor Author

The problems are something related with animal module

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-portal_partner_data_no_edit branch from 2dec447 to 3a6979d Compare November 8, 2022 08:06
sergio-teruel
sergio-teruel approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review!!

chienandalu
chienandalu approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Thanks! 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1393-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f69988e into OCA:15.0 Nov 8, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1e6f25e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CarlosRoca13 @pedrobaeza @OCA-git-bot @chienandalu @sergio-teruel @victoralmau @JoelZilli