Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] portal_partner_data_no_edit #1343

Closed

Conversation

JoelZilli
Copy link

No description provided.

@oca-clabot
Copy link

Hey @JoelZilli, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@JoelZilli JoelZilli changed the title 15.0 mig portal partner data no edit [MIG] portal_partner_data_no_edit Sep 19, 2022
@JoelZilli JoelZilli force-pushed the 15.0-mig-portal_partner_data_no_edit branch from b19d9dc to 5ec78c5 Compare September 21, 2022 15:29
@rousseldenis
Copy link
Contributor

/ocabot migration portal_partner_data_no_edit

@rousseldenis
Copy link
Contributor

@JoelZilli Thanks for this. Could you check your CLA and tests ?

@JoelZilli
Copy link
Author

@rousseldenis I`m checking the CLA. But for the tests, do you have any suggestion on how to proceed with the error? Because it says that it comes from the "Odoo Tour" test and i have never did anything with that kind on functionality.

@rousseldenis
Copy link
Contributor

Maybe @chienandalu @pedrobaeza can help as I'm not doing so much portal.

@sergio-teruel
Copy link
Contributor

@CarlosRoca13 Can you take a look at it?

@sergio-teruel
Copy link
Contributor

This migration is not worked as expected

1.- I block de edition in portal
image

2.- I can update my data (See the gif)
Peek 2022-11-03 22-02

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoelZilli

The tours are meant to test the module features as the user should experience. They use a headless browser and javascript scripts that follow that steps (go to a page, click on this link, assert that an element is visible or not, etc)

As a reference, you can check Odoo's docs on that matter: https://www.odoo.com/documentation/15.0/developer/reference/backend/testing.html#integration-testing

In the other hand, a simple functional review by a human showed up that the module doesn't do what was meant to do...

@pedrobaeza
Copy link
Member

Superseded by #1393

@pedrobaeza pedrobaeza closed this Nov 7, 2022
@jjscarafia jjscarafia deleted the 15.0-mig-portal_partner_data_no_edit branch November 15, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants