-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] portal_partner_data_no_edit #1343
[MIG] portal_partner_data_no_edit #1343
Conversation
Hey @JoelZilli, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
b19d9dc
to
5ec78c5
Compare
/ocabot migration portal_partner_data_no_edit |
@JoelZilli Thanks for this. Could you check your CLA and tests ? |
@rousseldenis I`m checking the CLA. But for the tests, do you have any suggestion on how to proceed with the error? Because it says that it comes from the "Odoo Tour" test and i have never did anything with that kind on functionality. |
Maybe @chienandalu @pedrobaeza can help as I'm not doing so much portal. |
@CarlosRoca13 Can you take a look at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JoelZilli
The tours are meant to test the module features as the user should experience. They use a headless browser and javascript scripts that follow that steps (go to a page, click on this link, assert that an element is visible or not, etc)
As a reference, you can check Odoo's docs on that matter: https://www.odoo.com/documentation/15.0/developer/reference/backend/testing.html#integration-testing
In the other hand, a simple functional review by a human showed up that the module doesn't do what was meant to do...
Superseded by #1393 |
No description provided.