Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] account_reconcile_model_oca: excludes account_accountant module #740

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

xaviedoanhduy
Copy link
Contributor

@xaviedoanhduy xaviedoanhduy commented Nov 12, 2024

This code of account_reconcile_model_oca was originally extracted from Odoo CE 16.0. Meanwhile the account.reconcile.model model evolved on its side in Odoo EE, with impactful methods signatures changes. As a consequence account_reconcile_model_oca is incompatible with Odoo EE, so we make it explicit by adding an excludes key in manifest.
account_accountant is the Accounting module in EE.

  • _get_invoice_matching_st_line_tokens in account_reconcile_model_oca is return a list in here
  • _get_invoice_matching_st_line_tokens in account_accountant is return a tuple (3 elements), so if list is empty _get_invoice_matching_st_line_tokens can be raise error in here:
  • account_accountant_batch_payment and sale_account_accountant in odoo EE can also cause errors when calling _get_invoice_matching_st_line_tokens expecting to get 3 values ​​from this method (example).

@xaviedoanhduy xaviedoanhduy force-pushed the 17.0-excludes_account_reconcile_model_oca branch from 4f6a667 to 608ab7d Compare November 12, 2024 04:05
@xaviedoanhduy xaviedoanhduy changed the title [ADD] excludes account_accountant module [17.0][IMP] account_reconcile_model_oca: excludes account_accountant module Nov 12, 2024
Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants