[17.0][IMP] account_reconcile_model_oca: excludes account_accountant module #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code of
account_reconcile_model_oca
was originally extracted from Odoo CE 16.0. Meanwhile theaccount.reconcile.model
model evolved on its side in Odoo EE, with impactful methods signatures changes. As a consequenceaccount_reconcile_model_oca
is incompatible with Odoo EE, so we make it explicit by adding an excludes key in manifest.account_accountant
is the Accounting module in EE._get_invoice_matching_st_line_tokens
inaccount_reconcile_model_oca
is return a list in here_get_invoice_matching_st_line_tokens
inaccount_accountant
is return a tuple (3 elements), so if list is empty_get_invoice_matching_st_line_tokens
can be raise error in here:account_accountant_batch_payment
andsale_account_accountant
in odoo EE can also cause errors when calling_get_invoice_matching_st_line_tokens
expecting to get 3 values from this method (example).