Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue error for unrecognized/missing config file entry #257

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

ishagokhale
Copy link
Contributor

added unit tests to check is exceptions were raised

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #257 (374fb49) into dev (9a44630) will increase coverage by 0.19%.
Report is 2 commits behind head on dev.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #257      +/-   ##
==========================================
+ Coverage   89.24%   89.43%   +0.19%     
==========================================
  Files          12       12              
  Lines         902      909       +7     
==========================================
+ Hits          805      813       +8     
+ Misses         97       96       -1     
Files Coverage Δ
casanovo/config.py 94.00% <100.00%> (+1.31%) ⬆️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ishagokhale ishagokhale marked this pull request as ready for review November 7, 2023 07:54
Copy link
Collaborator

@melihyilmaz melihyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@melihyilmaz melihyilmaz merged commit 235420f into dev Nov 9, 2023
6 checks passed
@melihyilmaz melihyilmaz deleted the config-entry branch November 9, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants