Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue an error for unrecognized config file entries #236

Closed
wsnoble opened this issue Aug 24, 2023 · 1 comment
Closed

Issue an error for unrecognized config file entries #236

wsnoble opened this issue Aug 24, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wsnoble
Copy link
Contributor

wsnoble commented Aug 24, 2023 •
edited
Loading

We recently renamed one of the parameters in the config file, and I used an old config file for a while without realizing that one of my parameters was incorrect and hence having no effect. I think we should modify the config file parser so that if the file contains any unrecognized entries, Casanovo stops with an error.

It should also stop with an error if there any of the expected entries is missing.
@bittremieux bittremieux added the enhancement New feature or request label Aug 24, 2023
@wsnoble wsnoble added the good first issue Good for newcomers label Sep 21, 2023
@ishagokhale ishagokhale reopened this Dec 11, 2023
@ishagokhale
Copy link
Contributor

resolved through PR #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bittremieux @wsnoble @ishagokhale