-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs based on Scott's feedback #478
Conversation
Looks like this replicates their dynamics now. Includes all the weights from their paper and splits the striatum into the three groups instead of wherever we got that one striatum block from.
If these plots are something specific to the paper and our API covers the data that is plotted then you don't have to add a recipe, just make a figure on the tutorial. If it's something more general then recipe would be better. |
This has some pretty significant changes that should address nearly all the points
The Parkinson's tutorial using Jansen-Rit models is significantly redone and ready for review @harisorgn. A couple important notes:
|
Thanks Anthony, looks good!
You can try matching the solver to see if this is the only difference like |
* update Getting Started text * change title and fix link in parkinsons * add seed and update plot in resting_state * remove outdated phrase * Fix the Parkinson's circuit to match Liu et al. 2020 Looks like this replicates their dynamics now. Includes all the weights from their paper and splits the striatum into the three groups instead of wherever we got that one striatum block from. * Prettify the introduction * Fix Jansen-Rit docstring to show defaults * Add dispatch of powerspectrum for neural masses * Overhaul of Parkinson's JR tutorial This has some pretty significant changes that should address nearly all the points --------- Co-authored-by: agchesebro <[email protected]>
Addresses docs feedback issues :