Refactor backend services to accept more configuration params in init #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejgray
approved these changes
Aug 8, 2024
NeonDaniel
added a commit
that referenced
this pull request
Aug 29, 2024
Update config handling to support `api_services` config outside of `keys` since #98 enabled more configuration options
NeonDaniel
added a commit
that referenced
this pull request
Sep 12, 2024
* Update warning log to use log_deprecation Update config handling to support `api_services` config outside of `keys` since #98 enabled more configuration options * Address review feedback * Update unit test GHA to resolve failure * Troubleshooting breaking changes in artifact upload action --------- Co-authored-by: Daniel McKnight <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors configuration handling to pass arbitrary configuration to backend services instead of just
api_keyUpdates all backend services to use a passed
cache_secondskwarg instead of hard-coded valuesUpdates all backend services to allow arbitrary kwargs to prevent configuration causing init errors and to enable service-specific configuration in the future
Issues
Other Notes