Update configuration handling #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update config handling to support `api_services` config outside of `keys` since #98 enabled more configuration options
mikejgray
approved these changes
Aug 31, 2024
NeonDaniel
force-pushed
the
FEAT_UpdateConfigHandling
branch
from
95a41a2 to
3beed12
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update warning log to use log_deprecation
Update config handling to support
api_servicesconfig outside ofkeyssince #98 enabled more configuration optionsIssues
Continues config options added in #98
Other Notes
This leaves backwards-compat for config but allows configuring
api_servicesoutside ofkeysconfiguration since config may contain more options than keys now. i.e.: