Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/app crashing because of wrong vc hierarchy #24

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ae88b1a
Full screen solution for inline player crash
manojalwisnz Oct 18, 2023
bf3cd5b
added pre-roll add close button to fullscren view
manojalwisnz Oct 25, 2023
de79284
NAT-28585: fixed ad timer issue on full screen
Oct 27, 2023
5aaeaa9
Merge pull request #22 from NZME/NAT-28585-ad-timer-not-showing-corre…
manojalwisnz Oct 27, 2023
4b6bcb8
removed ad close button
manojalwisnz Oct 31, 2023
1bef63e
added ad resume button when app whent to inactive state and come back…
manojalwisnz Nov 1, 2023
a56a590
1. on Android, upgrade to support GMA SDK version 22.6.0; on iOS, upg…
jazdance Feb 15, 2024
b777be2
according to release note, for GMA SDK 22.6.0, it requires compleSdkV…
jazdance Feb 21, 2024
b0fde25
because the external GDPR module only supports GMA SDK 22.4.0, so we …
jazdance Feb 21, 2024
4fd9b8e
- Update the dependencies to match the latest feature branch
YahiaRagae Jun 26, 2024
d74db2d
- Bump library version to `2.3.6`
YahiaRagae Jun 26, 2024
70c50bf
- Add pods of the iOS library to `git ignore`
YahiaRagae Jun 26, 2024
f1034f4
- Fix project file and add pods
YahiaRagae Jun 30, 2024
51d6177
- remove the `fullScreenCloseBtn`
YahiaRagae Jun 30, 2024
5187f03
- execlude tests from podspec
YahiaRagae Jul 1, 2024
d93608e
- Reorganize `BrightcoveIMAPlayerView` for more redability
YahiaRagae Jul 2, 2024
304c941
- Execlude `pod*` from the podspec
YahiaRagae Jul 2, 2024
4a3e90f
- Fix finiding the VC
YahiaRagae Jul 2, 2024
9a71338
- remove `adDisplayView` and `adResumeButton` since they are not bein…
YahiaRagae Jul 7, 2024
dbaaaf2
- Add `UIApplication+CurrentViewController` Category to help getting …
YahiaRagae Jul 8, 2024
bbd8c2d
- Add `TestHost` to host the unittestes that needs the UIApplication
YahiaRagae Jul 9, 2024
78b060f
- make sure `BrightcoveImaPlayerTest` has been execluded
YahiaRagae Jul 9, 2024
209b0e7
- Change `CurrentViewController` to be `CurrentNonAdViewController`
YahiaRagae Oct 7, 2024
4e7ae79
Bump package version for GOOGLE_IMA_SDK_VERSION to support android 14
mharrison-nzme Nov 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ android.iml
# Cocoapods
#
example/ios/Pods
ios/Pods

# node.js
#
Expand Down
6 changes: 3 additions & 3 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ def safeExtGet(prop, fallback) {
}

android {
compileSdkVersion safeExtGet('BrightcoveImaPlayer_compileSdkVersion', 29)
compileSdkVersion safeExtGet('BrightcoveImaPlayer_compileSdkVersion', 33)
defaultConfig {
minSdkVersion safeExtGet('BrightcoveImaPlayer_minSdkVersion', 19)
targetSdkVersion safeExtGet('BrightcoveImaPlayer_targetSdkVersion', 29)
minSdkVersion safeExtGet('BrightcoveImaPlayer_minSdkVersion', 24)
targetSdkVersion safeExtGet('BrightcoveImaPlayer_targetSdkVersion', 33)
versionCode 1
versionName "1.0"

Expand Down
2 changes: 1 addition & 1 deletion android/constants.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
project.ext {
BRIGHTCOVE_VERSION = '6.18.6'
PLAY_SERVICES_VERSION = '20.3.0'
PLAY_SERVICES_VERSION = '22.6.0'
GOOGLE_IMA_SDK_VERSION = '3.21.1'
ANDROIDX_LEGACY_SUPPORT_V4 = '1.0.0'
ANDROIDX_MEDIA = '1.1.0'
Expand Down
12 changes: 12 additions & 0 deletions ios/BrightcoveIMAPlayerView.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,15 @@

@interface BrightcoveIMAPlayerView : UIView<BCOVIMAPlaybackSessionDelegate>

#pragma mark - Playback properties

@property (nonatomic) BCOVPlaybackService *playbackService;
@property (nonatomic) id<BCOVPlaybackController> playbackController;
@property (nonatomic) id<BCOVPlaybackSession> playbackSession;
@property (nonatomic) BCOVPUIPlayerView *playerView;

#pragma mark - State properties

@property (nonatomic) BOOL playing;
@property (nonatomic) BOOL adsPlaying;
@property (nonatomic) BOOL autoPlay;
Expand All @@ -34,10 +39,15 @@
@property (nonatomic) NSTimeInterval currentVideoDuration;
@property (nonatomic) BOOL inViewPort;

#pragma mark - Configuration properties

@property (nonatomic, copy) NSDictionary *settings;
@property (nonatomic, copy) NSString *videoId;
@property (nonatomic, copy) NSString *accountId;
@property (nonatomic, copy) NSString *policyKey;

#pragma mark - Event callback properties

@property (nonatomic, copy) RCTDirectEventBlock onAdsLoaded;
@property (nonatomic, copy) RCTDirectEventBlock onReady;
@property (nonatomic, copy) RCTDirectEventBlock onPlay;
Expand All @@ -49,6 +59,8 @@
@property (nonatomic, copy) RCTDirectEventBlock onEnterFullscreen;
@property (nonatomic, copy) RCTDirectEventBlock onExitFullscreen;

#pragma mark - Public methods

-(void) setupWithSettings:(NSString*)settings;
-(void) seekTo:(NSNumber *)time;
-(void) toggleFullscreen:(BOOL)isFullscreen;
Expand Down
Loading