-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/app crashing because of wrong vc hierarchy #24
base: main
Are you sure you want to change the base?
Conversation
…ctly Nat 28585 ad timer not showing correctly
…rade to support GMA SDK version 10.10.0, also raised the miminum deployment target to ios 12.4.
…ersion to be >=33.
…have to drop GMA SDK version to 22.4.0 as well (from 22.6.0)
- Update `react-native` from `0.63.4` -> to `0.68.0` - Add `bob` to simplify the process of building your React Native library for both JavaScript and native code - Add `patch-package` to patch dome issues at the iOS code base
- remove the logic for fullscreen
- Add Logic to search for the `currentViewController`
- Fix full screen VC
…g used anymore - remove commented out code
…the `currentViewController` - Update `BrightcoveIMAPlayerView` to use the new `UIApplication+CurrentViewController`
- Add Unit Tests - Remove the case of `UISplitViewController` for now since it needs more time to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very thoughtful you also merged the previous PR with upgraded version of GMA SDK, into this PR already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like more code changes are required to cater for the scenario below:
on iphone,
if an article contains multiple videos,
right after start playing video A whose pre-roll video ad is playing...
scroll down to video B on the same article, click & start playing video B, the app will crash.
- Update `BrightcoveIMAPlayerView`
|
Fix: App Crashing Due to Wrong View Controller Hierarchy
Changes
Enhancements:
UIApplication+ CurrentNonAdViewController
category for gettingcurrentNonAdViewController
.BrightcoveIMAPlayerView
to use the new category.TestHost
to host unit tests requiringUIApplication
.Cleanup and Reorganization:
adDisplayView
andadResumeButton
.fullScreenCloseBtn
and fullscreen logic.BrightcoveIMAPlayerView
for readability.Updates:
2.3.6
.react-native
from0.63.4
to0.68.0
.bob
to simplify building the React Native library.patch-package
to patch iOS codebase issues.Exclusions:
BrightcoveImaPlayerTest
.