Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add HRRR CONUS grid #19

Merged
merged 7 commits into from
Sep 30, 2024
Merged

add HRRR CONUS grid #19

merged 7 commits into from
Sep 30, 2024

Conversation

simonbyrne
Copy link
Collaborator

Adds support for a Lambert Conformal Conic projection (used by the HRRR CONUS data)

cc @nbren12

nbren12
nbren12 requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@nbren12 nbren12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Some nits below which are optional, but please run the linter and fix any issues that come up.

earth2grid/lcc.py Show resolved Hide resolved
earth2grid/lcc.py Outdated Show resolved Hide resolved
earth2grid/lcc.py Outdated Show resolved Hide resolved
earth2grid/lcc.py Outdated Show resolved Hide resolved
earth2grid/lcc.py Outdated Show resolved Hide resolved
earth2grid/lcc.py Outdated Show resolved Hide resolved
tests/test_lcc.py Outdated Show resolved Hide resolved
@simonbyrne simonbyrne requested a review from nbren12 September 30, 2024 21:46
@nbren12
Copy link
Collaborator

nbren12 commented Sep 30, 2024

LGTM

@nbren12 nbren12 merged commit 6197c98 into NVlabs:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbren12 nbren12 Awaiting requested review from nbren12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonbyrne @nbren12