Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bye bye harmonics weight 5 #210

Merged
merged 4 commits into from
Feb 10, 2023
Merged

bye bye harmonics weight 5 #210

merged 4 commits into from
Feb 10, 2023

Conversation

giacomomagni
Copy link
Collaborator

@giacomomagni giacomomagni commented Feb 9, 2023

To facilitate #202 and delete unused stuff, we move the harmonics weight 5 in an independent package provided in extras.
Note that only S5 and Sm5 will remain in eko (since they are actually used).

@giacomomagni giacomomagni added the refactor Refactor code label Feb 9, 2023
@giacomomagni giacomomagni self-assigned this Feb 9, 2023
@t7phy
Copy link
Member

t7phy commented Feb 9, 2023

To facilitate #202 and delete unused stuff, we move the harmonics weight 5 in an independent package provided in extras. Note that only S5 and Sm5 will remain in eko (since they are actually used).

But what is the purpose of separating it? This would break the cache in #202

@giacomomagni
Copy link
Collaborator Author

giacomomagni commented Feb 9, 2023

But what is the purpose of separating it? This would break the cache in #202

These functions are never used inside any expression implemented in ekore so far (I hope you won't need them as well. Note that S5 and Sm5 will remain in ekore),
so they are actually a leftover of an old implementation of some N3LO matching condition which is now given parametrised. Keeping them in ekore is just slowing down the compilation and maintenance.

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely fine. I added a couple of suggested simplifications to the package, but you can even skip and merge. As you wish.

extras/harmonics_w5/pyproject.toml Outdated Show resolved Hide resolved
extras/harmonics_w5/pyproject.toml Outdated Show resolved Hide resolved
@giacomomagni giacomomagni merged commit ebe3e7e into master Feb 10, 2023
@giacomomagni giacomomagni deleted the removal_f_functions branch February 10, 2023 08:51
@felixhekhorn felixhekhorn mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants