Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N3LO ad variations #148

Merged
merged 97 commits into from
Apr 28, 2023
Merged

N3LO ad variations #148

merged 97 commits into from
Apr 28, 2023

Conversation

giacomomagni
Copy link
Collaborator

@giacomomagni giacomomagni commented Sep 13, 2022

N3LO anomalous dimension variations.

  • We will provide around 20 parametrisation for each singlet ad entry. The "best" N3LO ad will be the average of the variations (0,0,0,0).
  • A new key should be added to the theory card (n3lo_ad_variation: (gg_var,gq_var, qg_var,qq_var))
  • We will not introduce any variation in the non singlet ad.

A new version of banana is required for the test to pass.

@giacomomagni giacomomagni self-assigned this Sep 13, 2022
@giacomomagni giacomomagni added enhancement New feature or request physics new physics features labels Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #148 (c391a17) into develop (6dcadf4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head c391a17 differs from pull request most recent head 53a0bf8. Consider uploading reports for the commit 53a0bf8 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files           78       78              
  Lines         3724     3821      +97     
===========================================
+ Hits          3724     3820      +96     
- Misses           0        1       +1     
Flag Coverage Δ
isobench ?
unittests 99.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eko/anomalous_dimensions/__init__.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as4/__init__.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as4/ggg.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as4/ggq.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as4/gps.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as4/gqg.py 100.00% <100.00%> (ø)
src/eko/evolution_operator/__init__.py 99.43% <100.00%> (-0.57%) ⬇️
src/eko/evolution_operator/grid.py 100.00% <100.00%> (ø)

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #148 (9216678) into develop (d81d78e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
- Coverage    99.95%   99.91%   -0.04%     
===========================================
  Files           96       96              
  Lines         4430     4885     +455     
===========================================
+ Hits          4428     4881     +453     
- Misses           2        4       +2     
Flag Coverage Δ
isobench 49.10% <ø> (-4.80%) ⬇️
unittests 99.91% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eko/anomalous_dimensions/__init__.py 100.00% <ø> (ø)
src/eko/anomalous_dimensions/as4/__init__.py 100.00% <ø> (ø)
src/eko/anomalous_dimensions/as4/ggg.py 100.00% <ø> (ø)
src/eko/anomalous_dimensions/as4/ggq.py 100.00% <ø> (ø)
src/eko/anomalous_dimensions/as4/gnsm.py 100.00% <ø> (ø)
src/eko/anomalous_dimensions/as4/gnsp.py 100.00% <ø> (ø)
src/eko/anomalous_dimensions/as4/gps.py 100.00% <ø> (ø)
src/eko/anomalous_dimensions/as4/gqg.py 98.33% <ø> (-1.67%) ⬇️
src/eko/evolution_operator/__init__.py 100.00% <ø> (ø)
src/eko/evolution_operator/grid.py 100.00% <ø> (ø)
... and 12 more

@felixhekhorn
Copy link
Contributor

As we are pushing for an eko update in nnpdf - can we merge this?

@giacomomagni
Copy link
Collaborator Author

As we are pushing for an eko update in nnpdf - can we merge this?

This is fine for me. Eventually if there will be other fixes needed once the fits are done we can open a new PR.

@alecandido
Copy link
Member

Fine by me: in principle is a massive change, and I didn't have time to review in details. But I won't in the near future, and part of this will be reviewed anyhow during the runner rework, so it is simpler to have in master rather than keeping on a separate branch

@giacomomagni
Copy link
Collaborator Author

giacomomagni commented Mar 29, 2023

Okay. If it's fine for you I'd like to merge. okay?

Copy link
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just focused on the things that could be potentially harmful (i.e. I avoided bechmarking the numbers). I did not find anything wrong but I found just a thing that could be probably made clearer.

@andreab1997
Copy link
Contributor

Moreover there are a lot of conflicts, could you please rebase or merge?

@felixhekhorn
Copy link
Contributor

To fix pre-commit: please check if the changed white-space for the .nb files makes any difference for Mathematica - I don't expect it ... in case it still does consider blacklisting them

the rest please commit (they should be safe ...)

@felixhekhorn
Copy link
Contributor

The moment pre-commit is taken care of we should finally merge this looong PR

@giacomomagni giacomomagni merged commit bde08e9 into master Apr 28, 2023
@giacomomagni giacomomagni mentioned this pull request Apr 28, 2023
1 task
@alecandido
Copy link
Member

🎉

@giacomomagni giacomomagni deleted the feature/N3LO_ad_variations branch May 3, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics new physics features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants