-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N3LO ad variations #148
N3LO ad variations #148
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
- Coverage 100.00% 99.97% -0.03%
===========================================
Files 78 78
Lines 3724 3821 +97
===========================================
+ Hits 3724 3820 +96
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Felix Hekhorn <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
- Coverage 99.95% 99.91% -0.04%
===========================================
Files 96 96
Lines 4430 4885 +455
===========================================
+ Hits 4428 4881 +453
- Misses 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Felix Hekhorn <[email protected]>
Co-authored-by: Felix Hekhorn <[email protected]>
As we are pushing for an eko update in nnpdf - can we merge this? |
This is fine for me. Eventually if there will be other fixes needed once the fits are done we can open a new PR. |
Fine by me: in principle is a massive change, and I didn't have time to review in details. But I won't in the near future, and part of this will be reviewed anyhow during the runner rework, so it is simpler to have in |
Okay. If it's fine for you I'd like to merge. okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just focused on the things that could be potentially harmful (i.e. I avoided bechmarking the numbers). I did not find anything wrong but I found just a thing that could be probably made clearer.
Moreover there are a lot of conflicts, could you please rebase or merge? |
To fix pre-commit: please check if the changed white-space for the the rest please commit (they should be safe ...) |
The moment pre-commit is taken care of we should finally merge this looong PR |
🎉 |
N3LO anomalous dimension variations.
(0,0,0,0)
.n3lo_ad_variation: (gg_var,gq_var, qg_var,qq_var)
)A new version of banana is required for the test to pass.