Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for article before rendering ASC-WDS news card on parent home page #6374

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Add check for article before rendering ASC-WDS news card on parent home page #6374

merged 1 commit into from
Oct 3, 2024

Conversation

duncanc19
Copy link
Collaborator

Work done

  • Added check for article object before rendering ASC-WDS news card on parent home page to ensure failure of CMS doesn't break parent home page

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

@duncanc19 duncanc19 marked this pull request as ready for review October 3, 2024 09:50
@duncanc19 duncanc19 merged commit b89255c into main Oct 3, 2024
5 checks passed
@duncanc19 duncanc19 deleted the fix/1523-load-parent-home-page-when-cms-fails branch October 3, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonopono123 Jonopono123 Jonopono123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanc19 @Jonopono123