Merge pull request #6374 from NMDSdevopsServiceAdm/fix/1523-load-pare…

…nt-home-page-when-cms-fails Add check for article before rendering ASC-WDS news card on parent home page
NMDSdevopsServiceAdm · Oct 3, 2024 · b89255c · b89255c
2 parents f4732ca + 0b0f651
commit b89255c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/frontend/src/app/features/new-dashboard/parent-home-tab/parent-home-tab.component.html b/frontend/src/app/features/new-dashboard/parent-home-tab/parent-home-tab.component.html
@@ -111,7 +111,7 @@
           </p></app-card
         >
       </div>
-      <div class="govuk-grid-column-one-third asc-card-padding">
+      <div *ngIf="article" class="govuk-grid-column-one-third asc-card-padding">
         <app-card [image]="'/assets/images/news.svg'">
           <a
             class="govuk-link--no-visited-state govuk-!-font-size-19 govuk-!-font-weight-bold"

diff --git a/frontend/src/app/features/new-dashboard/parent-home-tab/parent-home-tab.component.spec.ts b/frontend/src/app/features/new-dashboard/parent-home-tab/parent-home-tab.component.spec.ts
@@ -50,6 +50,7 @@ describe('ParentHomeTabComponent', () => {
     comparisonDataAvailable = true,
     noOfWorkplaces = 9,
     permissions = [],
+    canAccessCms = true,
   ) => {
     const { fixture, queryAllByText, getByText, queryByText, getByTestId, queryByTestId } = await render(
       ParentHomeTabComponent,
@@ -76,8 +77,8 @@ describe('ParentHomeTabComponent', () => {
             useValue: {
               snapshot: {
                 data: {
-                  articleList,
-                  articles,
+                  articleList: canAccessCms ? articleList : null,
+                  articles: canAccessCms ? articles : null,
                   workers: {
                     workersCreatedDate: [],
                     workerCount: 0,
@@ -304,6 +305,14 @@ describe('ParentHomeTabComponent', () => {
       expect(ascWdsNewsLink).toBeTruthy();
       expect(ascWdsNewsLink.getAttribute('href')).toContain(articleList.data[0].slug);
     });
+
+    it('should not show an ASC-WDS news card when user cannot access CMS', async () => {
+      const { queryByText } = await setup(false, Establishment, true, 9, [], false);
+
+      const ascWdsNewsLink = queryByText('ASC-WDS news');
+
+      expect(ascWdsNewsLink).toBeFalsy();
+    });
   });
 
   describe('summary', () => {