Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable leaf phenology when running Static Stand Structure (ST3) Mode #1129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable leaf phenology when running Static Stand Structure (ST3) Mode #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb4af1a
Allow stocks to be written in the output when running ST3 mode
mpaiao Dec 7, 2023
c7bc662
First attempt to incorporate phenology to ST3 mode.
mpaiao Dec 7, 2023
a0526bd
Uncommenting the return that bypasses output of structure variables w…
mpaiao Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions main/EDMainMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,13 @@ subroutine ed_ecosystem_dynamics(currentSite, bc_in, bc_out)
! Zero mass balance
call TotalBalanceCheck(currentSite, 0)

! We do not allow phenology while in ST3 mode either, it is hypothetically
! possible to allow this, but we have not plugged in the litter fluxes
! of flushing or turning over leaves for non-dynamics runs
if (hlm_use_ed_st3.eq.ifalse)then
if(hlm_use_sp.eq.ifalse) then
call phenology(currentSite, bc_in )
else
call satellite_phenology(currentSite, bc_in )
end if ! SP phenology
end if
! Phenology. For now ST3 mode also represents phenology, though it is
! an incomplete representation as it lacks transfers to the litter layer
if (hlm_use_sp == ifalse) then
call phenology(currentSite, bc_in )
else
call satellite_phenology(currentSite, bc_in )
end if ! SP phenology


if (hlm_use_ed_st3.eq.ifalse.and.hlm_use_sp.eq.ifalse) then ! Bypass if ST3
Expand Down
8 changes: 8 additions & 0 deletions parteh/PRTLossFluxesMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ module PRTLossFluxesMod
use FatesConstantsMod, only : nearzero
use FatesConstantsMod, only : calloc_abs_error
use FatesConstantsMod, only : itrue
use FatesInterfaceTypesMod, only : hlm_use_ed_st3
use FatesGlobals , only : endrun => fates_endrun
use FatesGlobals , only : fates_log
use shr_log_mod , only : errMsg => shr_log_errMsg
Expand Down Expand Up @@ -567,6 +568,13 @@ subroutine DeciduousTurnoverSimpleRetranslocation(prt,ipft,organ_id,mass_fractio

if( prt_params%organ_param_id(organ_id) < 1 ) then
retrans = 0._r8
else if (hlm_use_ed_st3 == itrue) then
! For now we retranslocate all biomass to storage to prevent carbon balance errors.
! This is not an ideal solution because tissue abscission may contribute to a
! seasonal sign in litter and consequently heterotrophic respiration (though the
! lack of phenology is also problematic for seasonal cycles of GPP, ET, sensible
! heat, etc.).
retrans = 1._r8
else
if ( element_id == carbon12_element ) then
retrans = 0._r8
Expand Down