Enable leaf phenology when running Static Stand Structure (ST3) Mode #1129
Conversation
1. Very simplistic approach, in which we impose retranslocation factor for all elements to be 1. This ensures carbon is available for regrowth and the carbon budget is closed. 2. This is not an ideal solution because leaf abscission would increase litter stocks and consequently modulate the seasonal cycle of heterotrophic respiration. That said, this is not necessarily worse than assuming leaf biomass is aseasonal in deciduous- dominated ecosystems, and that litter stocks would need to change based on environmentally driven seasonality of heterotrophic respiration.
|
I think its fair to ignore heterotrophic seasonality, and litter fluxes. They were not there before, so we are not losing process functionality, only gaining processes functionality. |
main/FatesHistoryInterfaceMod.F90
Outdated
| @@ -2508,7 +2508,7 @@ subroutine update_history_dyn(this,nc,nsites,sites,bc_in) | |||
| hio_lai_si => this%hvars(ih_lai_si)%r81d ) | |||
|
|
|||
| ! If we don't have dynamics turned on, we just abort these diagnostics | |||
| if (hlm_use_ed_st3.eq.itrue) return | |||
There was a problem hiding this comment.
I'm working on breaking up the history calls (in another PR) so that we are not processing variables that are not desired or active. My take, is that by removing this line, the user can now view phenologically relevant output?
There was a problem hiding this comment.
To be honest, I had removed this because I wanted to see the computed forest structure properties in the output, and forgot to uncomment it back for the PR. But you are right, this return may disable variables that are now going to change due to phenology. Perhaps we could move the phenology-related variables before the if and keep the others after the if?
There was a problem hiding this comment.
my intention in the PR that cleans up history was to enable diagnostics that show forest structure and states, and to turn off flux variables (with st3 AND Sat Phen). So, if you don't have a strong preference for this PR, lets just keep the return in there to make testing more straight forward?
There was a problem hiding this comment.
Sure, I can uncomment it.
Maybe a topic for the other PR, but wouldn't you want to output flux variables (and LAI) when using ST3 and SP modes, and turn off the other forest structure and states (as they wouldn't vary in these modes)?
…hen using ST3 mode.
|
Regression testing is queued on cheyenne. |
|
Regression testing is showing that the ST3 mode does not pass exact restart currently. Looking into this. All other expected tests are B4B. |
glemieux
added
the
stuck
Description:
Leaf phenology was by default disabled when running ST3 mode, which limits its application in deciduous-dominated area (e.g., when assessing fluxes given a stand). This pull request partially addresses this.
Collaborators:
@ckoven @rgknox @rosiealice
Expectation of Answer Changes:
Results should change when running FATES in ST3 mode.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: