Store active role in cookie instead of token #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camargo
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
camargo
added
the
refactor
duranb
reviewed
Sep 13, 2023
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When discussing the change role endpoint in the Gateway with @mattdailis, he pointed out we don't really need it and can just store the active role in a cookie like we do with the user. This greatly simplifies the Gateway API, and makes it easier to maintain. We still get security because Hasura automatically does the role check via the
x-hasura-roleheader.To test:
Gateway PR: NASA-AMMOS/aerie-gateway#44