Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove change role endpoint #44

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Remove change role endpoint #44

merged 1 commit into from
Sep 13, 2023

Conversation

camargo
Copy link
Member

@camargo camargo commented Sep 13, 2023 •
edited
Loading

@camargo camargo self-assigned this Sep 13, 2023
@camargo camargo added the refactor A code change that neither fixes a bug nor adds a feature label Sep 13, 2023
@camargo camargo mentioned this pull request Sep 13, 2023
Merged
@camargo camargo force-pushed the refactor/remove-change-role-endpoint branch from f96bf1a to d242115 Compare September 13, 2023 17:13
@camargo camargo requested a review from duranb September 13, 2023 20:33
duranb
duranb approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😢

@camargo camargo merged commit f9829d9 into develop Sep 13, 2023
2 checks passed
@camargo camargo deleted the refactor/remove-change-role-endpoint branch September 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

Assignees

@camargo camargo

Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate that RequestedRole is an AllowedRole in ChangeRole endpoint
2 participants
@camargo @duranb