Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor module #25

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
9105fb8
Initial change so that the tools and tests are in a module directory.…
markmcdowall Jul 5, 2018
05d21cd
Description of the changes in the ADR
markmcdowall Jul 5, 2018
71a3b65
Changes required due tothe change in locations of tests and documenta…
markmcdowall Jul 5, 2018
d54fe5b
More fixes for the dir change
markmcdowall Jul 5, 2018
f19b7a7
More fixes for the dir change
markmcdowall Jul 5, 2018
3fc7008
Fix to the docs
markmcdowall Jul 5, 2018
4e6047d
Updates to the adr
markmcdowall Jul 11, 2018
36ad66c
Merge branch 'master' into refactor_module
markmcdowall Jul 11, 2018
377b252
Merge branch 'master' into refactor_module
markmcdowall Jul 11, 2018
6fe1bb4
Merged in DCs changes to the TADbit tools from master into the refact…
markmcdowall Jul 18, 2018
97a545f
Merge branch 'master' into refactor_module
markmcdowall Jul 18, 2018
a0d6916
Merge branch 'master' into refactor_module
markmcdowall Jul 31, 2018
942db6f
Merged changes from master
markmcdowall Aug 2, 2018
bfe3ce7
Merge branch 'master' into refactor_module
markmcdowall Aug 3, 2018
61150ec
Fixed merge conflicts
markmcdowall Aug 15, 2018
45bcf6c
Merged in changes from master
markmcdowall Sep 14, 2018
9184fc9
Added more verbosity to the trimgalore tool when reporting missing ou…
markmcdowall Sep 27, 2018
4e5eabf
Merging in changes from the master branch
markmcdowall Sep 27, 2018
7815a23
Changes to account for the dir changes in the tests
markmcdowall Sep 27, 2018
856706e
Merge branch 'master' into refactor_module
markmcdowall Sep 27, 2018
6f19c6f
Fix to the FASTQ output handling for paired end data
markmcdowall Sep 27, 2018
de60472
Merged in changes from master for RNA-seq pipeline changes
markmcdowall Oct 2, 2018
e55223e
Fixed imports for the TADbit pipelines and tests
markmcdowall Oct 2, 2018
cb31e0c
Updated missed import
markmcdowall Oct 2, 2018
66c4652
Correction to the imports for teh TADbit modules
markmcdowall Oct 2, 2018
efb6846
Merge branch 'master' into refactor_module
markmcdowall Oct 4, 2018
9af2add
Merged in changes from the master branch
markmcdowall Oct 22, 2018
0549929
Initial change so that the workflows are a separate module, like the …
markmcdowall Oct 22, 2018
0cf6ba8
Added a note to the ADR for the start of work for moving the workflow…
markmcdowall Oct 22, 2018
0e6efd0
Converted genome indexing, RNA-seq and WGBS pipelines to use the new …
markmcdowall Oct 22, 2018
83e6a39
Initial changes to the 4 major pipelines test scripts to match the wo…
markmcdowall Oct 22, 2018
cede75b
Merged in changes from master
markmcdowall Oct 22, 2018
8e4fe32
Update for teh MNase-Seq workflow
markmcdowall Oct 22, 2018
1b66921
Added in Bowtie2, BWA ALN and BWA MEM to use the new workflow structure
markmcdowall Oct 22, 2018
24c1469
Merged in the changes from master
markmcdowall Oct 24, 2018
1673387
Fixed class naming
markmcdowall Oct 24, 2018
cb18eb2
Modified the workflow to use BWA MEM rather than BWA ALN
markmcdowall Oct 24, 2018
177f386
Adding the Workflow documentation to the docs for RTD
markmcdowall Oct 24, 2018
ba6d919
Description about the change of the aligner for ChIP-seq
markmcdowall Oct 24, 2018
2ffe793
Removed the methods sections from the pipelines.rst in preparation fo…
markmcdowall Oct 24, 2018
f135ab8
Added in all the current workflows that have been moved over to the r…
markmcdowall Oct 24, 2018
ea60731
Moved BioBamBam2 to use the new structure
markmcdowall Oct 30, 2018
58f8167
Merged in the changes from master
markmcdowall Oct 30, 2018
d0d1920
Generic pipeline to run all workflows and pipelines. This should redu…
markmcdowall Oct 30, 2018
01cbfa7
Fixed the import of common within the idear module
markmcdowall Oct 30, 2018
bbb9253
Fixed try statement
markmcdowall Oct 30, 2018
593dc0e
Merge branch 'master' into refactor_module
markmcdowall Oct 30, 2018
2647351
Merge branch 'master' into refactor_module
markmcdowall Oct 30, 2018
c76d538
Moved test data
markmcdowall Oct 31, 2018
4810404
Fixed teh test for the RNA-seq pipeline
markmcdowall Oct 31, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ before_script:
- chmod +x scripts/travis/wgbs_harness.sh
- chmod +x scripts/travis/docs_harness.sh
- chmod +x scripts/travis/pylint_harness.sh
- ls tests/data/
- git status

- export PATH="${HOME}/bin:$PATH"
Expand Down
18 changes: 17 additions & 1 deletion docs/adr.rst
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,21 @@ Other changes include:
2018-06-27 - Remove reads marked as duplicate by BioBamBam
----------------------------------------------------------

BioBamBam only marks reads as duplicate, but does not remove the after. The Tool has been updated to remove the flagged duplicates using samtools with the parameter `-F 1024`. This matches the pipeline used within the `Blueprints project <http://dcc.blueprint-epigenome.eu/#/md/chip_seq_grch37>`_.
BioBamBam only marks reads as duplicate, but does not remove them after. The Tool has been updated to remove the flagged duplicates using samtools with the parameter `-F 1024`. This matches the pipeline used within the `Blueprints project <http://dcc.blueprint-epigenome.eu/#/md/chip_seq_grch37>`_.

Also performed some tidying of the code to annotate issues that had been highlighted by pylint.


2018-07-05 - Refactoring of repo to avoid naming collisions
-----------------------------------------------------------

The original repo had the tools and tests in a directory that was in the root of the repo. This is problematic when there is sharing of the code as there are collisions in the name space. This has meant that all of the code needs to be moved into a new subdirectory (mg_process_fastq).

There is also the movement of the workflow classes out of the pipeline scripts and into their own module in mg_process_fastq. This means that tworkflows that have been written by others can be more easily imported.

This change will probably necessitate incrementing the major release number to 1.0.0 as this is not a backwards compatible change and will require changes in other repos that rely on mg-process-fastq. As a result this will need to be part of a planned release with other developers.


2018-07-11 - Changes FASTQ splitter file management
---------------------------------------------------

Expand Down Expand Up @@ -227,3 +237,9 @@ Ability to handle multiple input single/paired end data and background data file
----------------------------------------------------------

The output wig files from BS Seeker2 are now converted to BigWig files by default rather than returning wig files. This is so that they are easier to visualise on the JBrowse interface.


2018-10-24 - ChIP-seq Pipeline to use BWA MEM
---------------------------------------------

Changed the default aligner for the ChIP-seq pipeline from BWA ALN to BWA MEM for speed improvements and better handling of short read data.
16 changes: 8 additions & 8 deletions docs/common.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,28 @@
Utility Functions
=================

.. automodule:: tool
.. automodule:: mg_process_fastq.tool

Common Functions
----------------

The following functions are ones that have been used across multiple tools for
transformations of the data when requried.

.. autoclass:: tool.common.cd
.. autoclass:: mg_process_fastq.tool.common.cd
:members:

Alignment Utilities
-------------------
.. autoclass:: tool.aligner_utils.alignerUtils
.. autoclass:: mg_process_fastq.tool.aligner_utils.alignerUtils
:members:

Bam Utilities
-------------
.. autoclass:: tool.bam_utils.bamUtils
.. autoclass:: mg_process_fastq.tool.bam_utils.bamUtils
:members:

.. autoclass:: tool.bam_utils.bamUtilsTask
.. autoclass:: mg_process_fastq.tool.bam_utils.bamUtilsTask
:members:

FASTQ Functions
Expand All @@ -52,7 +52,7 @@ Utility Functions
The following functions are to provide easy access for iterating through entries
within a FASTQ file(s) both single and paired.

.. autoclass:: tool.fastqreader.fastqreader
.. autoclass:: mg_process_fastq.tool.fastqreader.fastqreader
:members:

Splitting
Expand All @@ -62,13 +62,13 @@ Utility Functions
chunks for parallel processing. It is able to work on single and paired end
files.

.. autoclass:: tool.fastq_splitter.fastq_splitter
.. autoclass:: mg_process_fastq.tool.fastq_splitter.fastq_splitter
:members:

Entry Functions
^^^^^^^^^^^^^^^

The following functions allow for manipulating FASTQ files.

.. autoclass:: tool.fastq_utils.fastqUtils
.. autoclass:: mg_process_fastq.tool.fastq_utils.fastqUtils
:members:
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
# Required to us the dummy_pycompss calls
sys._run_from_cmdl = True

import tool
import mg_process_fastq.tool

from mock import Mock as MagicMock

Expand Down
1 change: 1 addition & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ MuG - FASTQ Pipelines's documentation!
full_installation
pipelines
tools
workflow
common
settingUpTravis
docker
Expand Down
113 changes: 0 additions & 113 deletions docs/pipelines.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,6 @@ Download and index genome files
--out_metadata tests/json/output_genome_indexer.json


Methods
=======

.. autoclass:: process_genome.process_genome
:members:


BioBamBam Alignment Filtering
-----------------------------
.. automodule:: process_biobambam
Expand Down Expand Up @@ -133,12 +126,6 @@ BioBamBam Alignment Filtering
--out_metadata tests/json/output_biobambam.json


Methods
=======
.. autoclass:: process_biobambam.process_biobambam
:members:


Bowtie2 Alignment
-----------------
.. automodule:: process_align_bowtie
Expand Down Expand Up @@ -207,12 +194,6 @@ Bowtie2 Alignment
--out_metadata tests/json/output_bowtie2_paired.json


Methods
=======
.. autoclass:: process_align_bowtie.process_bowtie
:members:


BSgenome Builder
----------------
.. automodule:: process_bsgenome
Expand Down Expand Up @@ -272,12 +253,6 @@ BSgenome Builder
--out_metadata tests/json/output_bsgenome.json


Methods
=======
.. autoclass:: process_bsgenome.process_bsgenome
:members:


BS Seeker2 Indexer
------------------
.. automodule:: process_bs_seeker_index
Expand Down Expand Up @@ -331,12 +306,6 @@ BS Seeker2 Indexer
--out_metadata tests/json/output_wgbs_index.json


Methods
=======
.. autoclass:: process_bs_seeker_index.process_bs_seeker_index
:members:


BS Seeker2 Aligner
------------------
.. automodule:: process_bs_seeker_aligner
Expand Down Expand Up @@ -393,12 +362,6 @@ BS Seeker2 Aligner
--out_metadata tests/json/output_wgbs_align.json


Methods
=======
.. autoclass:: process_bs_seeker_aligner.process_bs_seeker_aligner
:members:


BiSulphate Sequencing Filter
----------------------------
.. automodule:: process_bs_seeker_filter
Expand Down Expand Up @@ -455,12 +418,6 @@ BiSulphate Sequencing Filter
--out_metadata tests/json/output_metadata.json


Methods
=======
.. autoclass:: process_bs_seeker_filter.process_bsFilter
:members:


BS Seeker2 Methylation Peak Caller
----------------------------------
.. automodule:: process_bs_seeker_peak_caller
Expand Down Expand Up @@ -520,12 +477,6 @@ BS Seeker2 Methylation Peak Caller
--out_metadata tests/json/output_wgbs_peak_caller.json


Methods
=======
.. autoclass:: process_bs_seeker_peak_caller.process_bs_seeker_peak_caller
:members:


BWA Alignment - bwa aln
-----------------------
.. automodule:: process_align_bwa
Expand Down Expand Up @@ -594,12 +545,6 @@ BWA Alignment - bwa aln
--out_metadata tests/json/output_bwa_aln_paired.json


Methods
=======
.. autoclass:: process_align_bwa.process_bwa
:members:


BWA Alignment - bwa mem
-----------------------
.. automodule:: process_align_bwa_mem
Expand Down Expand Up @@ -668,12 +613,6 @@ BWA Alignment - bwa mem
--out_metadata tests/json/output_bwa_mem_paired.json


Methods
=======
.. autoclass:: process_align_bwa_mem.process_bwa_mem
:members:


ChIP-Seq Analysis
-----------------
.. automodule:: process_chipseq
Expand Down Expand Up @@ -729,12 +668,6 @@ ChIP-Seq Analysis
--out_metadata tests/json/output_chipseq.json


Methods
=======
.. autoclass:: process_chipseq.process_chipseq
:members:


iDamID-Seq Analysis
-------------------
.. automodule:: process_damidseq
Expand Down Expand Up @@ -788,12 +721,6 @@ iDamID-Seq Analysis
--in_metadata tests/json/input_idamidseq.json \
--out_metadata tests/json/output_idamidseq.json


Methods
=======
.. autoclass:: process_damidseq.process_damidseq
:members:

iNPS
----
.. automodule:: process_iNPS
Expand Down Expand Up @@ -848,12 +775,6 @@ iNPS
--out_metadata tests/json/output_iNPS.json


Methods
=======
.. autoclass:: process_iNPS.process_iNPS
:members:


MACS2 Analysis
--------------
.. automodule:: process_macs2
Expand Down Expand Up @@ -921,12 +842,6 @@ MACS2 Analysis
--out_metadata tests/json/output_macs2_bgd.json


Methods
=======
.. autoclass:: process_macs2.process_macs2
:members:


Mnase-Seq Analysis
------------------
.. automodule:: process_mnaseseq
Expand Down Expand Up @@ -981,12 +896,6 @@ Mnase-Seq Analysis
--out_metadata tests/json/output_mnaseseq.json


Methods
=======
.. autoclass:: process_mnaseseq.process_mnaseseq
:members:


RNA-Seq Analysis
----------------
.. automodule:: process_rnaseq
Expand Down Expand Up @@ -1039,11 +948,6 @@ RNA-Seq Analysis
--in_metadata tests/json/input_rnaseq.json \
--out_metadata tests/json/output_rnaseq.json

Methods
=======
.. autoclass:: process_rnaseq.process_rnaseq
:members:


TrimGalore
----------
Expand Down Expand Up @@ -1101,12 +1005,6 @@ TrimGalore
--out_metadata tests/json/output_trimgalore.json


Methods
=======
.. autoclass:: process_trim_galore.process_trim_galore
:members:


Whole Genome BiSulphate Sequencing Analysis
-------------------------------------------
.. automodule:: process_wgbs
Expand Down Expand Up @@ -1165,12 +1063,6 @@ Whole Genome BiSulphate Sequencing Analysis
--in_metadata tests/json/input_wgbs.json \
--out_metadata tests/json/output_wgbs.json


Methods
=======
.. autoclass:: process_wgbs.process_wgbs
:members:

Hi-C Analysis
-------------

Expand Down Expand Up @@ -1271,8 +1163,3 @@ Hi-C Analysis
--normalized 1 \
--tag Human.SRR1658573 \
--window_type frag

Methods
=======
.. autoclass:: process_hic.process_hic
:members:
Loading