Refactor module #25
Open
Refactor module #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This is to avoid dir collisions with other repos
rehamFatima
reviewed
Jul 10, 2018
docs/adr.rst
Outdated
| @@ -128,3 +128,11 @@ Other changes include: | |||
| BioBamBam only marks reads as duplicate, but does not remove the after. The Tool has been updated to remove the flagged duplicates using samtools with the parameter `-F 1024`. This matches the pipeline used within the `Blueprints project <http://dcc.blueprint-epigenome.eu/#/md/chip_seq_grch37>`_. | |||
docs/adr.rst
Outdated
| 2018-07-05 - Refactoring of repo to avoid naming collisions | ||
| ----------------------------------------------------------- | ||
|
|
||
| The original repo had the tools and tests in a directory that was in the root of the repo. This is problematic when there is sharing of the code as there are collisions in teh name space. This has meant that all of the code needs to be moved into a new subdirectory (mg_process_fastq). |
| @@ -1,3 +1,3 @@ | |||
| [pytest] | |||
| #testpaths = tests | |||
| #testpaths = mg_process_fastq/tests | |||
| norecursedirs = data tmp* env docs apps basic_modules *.egg_info TADbit-master | |||
…tools to allow for easy importing into other pipelines.
…r moving this to the workflow.rst file
…efactored arrangement
…ce code duplication and allow for this script to be used as a single as part of the mg-tool-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code refactoring to avoid namespace collisions when there are multiple repos that have used the same template