forked from edbee/edbee-lib
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update our fork of edbee-lib with latest master #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile fix for README example
…sible incompatibility with older releases!
…r controller->setReadonly() Update CMakeList.txt
…hanges, to prevent updating per item)
Support for sticky-selection in replaceSelection methods. (Required for InpuMethod entry) Improved TextEditorComponent::InputMethodEvent... It now support special chars entry like expected. (Option+e, e => ´ => é) - Fixed gapvector destructor: it did not use an array delete. - TextEditorWidget::setHorizontalScrollBar not emits the correct horizontalScrollBarChanged event.
A use of the above in the test code fails to build on anything older than Qt 5.14 as the `enum` used is only present in that and newer versions. Previously the `enum` was a member of the `QString` class rather than the `Qt` namespace... Signed-off-by: Stephen Lyons <[email protected]>
…Versions Revise: fix QString::split(...) for older Qt Versions
SlySven
reviewed
Nov 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that our usage of Travis is fu-ed if not fubar-ed now - we should dump the CI on that platform and (ideally) replace it with something else...
This was referenced Nov 8, 2020
Sure. Want to approve this though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike #6 this does not cherrypick the commits but just merges them, which is cleaner for Git history.