Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: use later version of Edbee #4198

Closed

Conversation

SlySven
Copy link
Member

@SlySven SlySven commented Oct 23, 2020

Changelog:

Signed-off-by: Stephen Lyons [email protected]

Changelog:
* Fixed cmake on mac os x
* Disabled TextEditorComponent::inputMethodEvent for Linux
* ref Mudlet#107, Several improvements  (Thanks @sebcaux) Support for sticky-selection in replaceSelection methods. (Required for InpuMethod entry) Improved TextEditorComponent::InputMethodEvent... It now support special chars entry like expected. (Option+e,  e => ´ => é) - Fixed gapvector destructor: it did not use an array delete. - TextEditorWidget::setHorizontalScrollBar not emits the correct horizontalScrollBarChanged event.
* ref Mudlet#106, Missing round function on SuSE. (Changed to qRound)
* ref Mudlet#99, Speed improvements for markAll. (Added beginChanges and endChanges, to prevent updating per item)
* ref Mudlet#96, Added support for readonly mode, via widget->setReadonly() or controller->setReadonly() Update CMakeList.txt
* wip readonly
* fixes #90, Several Qt deprecation warnings. Changed 0 to nullptr. Possible incompatibility with older releases!
* removed incorrect include file
* fix Mudlet#101, Support for JSON based grammar files.
* Merge pull request Mudlet#102 from emoon/readme-fix
* Merge branch 'Mudlet-master' (with some additions/changes)

Signed-off-by: Stephen Lyons <[email protected]>
@add-deployment-links
Copy link

add-deployment-links bot commented Oct 23, 2020

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@SlySven
Copy link
Member Author

SlySven commented Oct 23, 2020

Damn, this revision contains code that required at least Qt 5.14. (it uses (QTextStream&) Qt::endl(QTextStream &stream) see: https://doc.qt.io/qt-5/qt.html#endl and that was introduced in that version). Given that Qt 5.12 LTS does not reach EOL until the end of next year (2021/12/05) this seems a little short-sighted...

@SlySven
Copy link
Member Author

SlySven commented Oct 26, 2020

That last commit added:

@vadi2
Copy link
Member

vadi2 commented Oct 26, 2020

We use a fork of edbee in https://github.com/Mudlet/edbee-lib because we had to make fixes to it previously, so that is what should be updated instead. Could you resubmit the PR there?

@vadi2 vadi2 assigned SlySven and unassigned vadi2 Oct 26, 2020
@SlySven
Copy link
Member Author

SlySven commented Oct 26, 2020

Humm, this is not going to be as simple as I thought - I didn't realise that we were still using our own custom fork of this library...

@SlySven SlySven marked this pull request as draft October 26, 2020 23:34
@SlySven
Copy link
Member Author

SlySven commented Oct 26, 2020

I will have to close this and start a fresh PR that cherry-picks all the commits in the upstream repository into our version...

@SlySven
Copy link
Member Author

SlySven commented Nov 8, 2020

Closing in favour of Mudlet/edbee-lib#6 Mudlet/edbee-lib#7 .

@SlySven SlySven closed this Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for json based grammar files Qt 5.13 deprecated warnings
2 participants