-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: use later version of Edbee #4198
Conversation
Changelog: * Fixed cmake on mac os x * Disabled TextEditorComponent::inputMethodEvent for Linux * ref Mudlet#107, Several improvements (Thanks @sebcaux) Support for sticky-selection in replaceSelection methods. (Required for InpuMethod entry) Improved TextEditorComponent::InputMethodEvent... It now support special chars entry like expected. (Option+e, e => ´ => é) - Fixed gapvector destructor: it did not use an array delete. - TextEditorWidget::setHorizontalScrollBar not emits the correct horizontalScrollBarChanged event. * ref Mudlet#106, Missing round function on SuSE. (Changed to qRound) * ref Mudlet#99, Speed improvements for markAll. (Added beginChanges and endChanges, to prevent updating per item) * ref Mudlet#96, Added support for readonly mode, via widget->setReadonly() or controller->setReadonly() Update CMakeList.txt * wip readonly * fixes #90, Several Qt deprecation warnings. Changed 0 to nullptr. Possible incompatibility with older releases! * removed incorrect include file * fix Mudlet#101, Support for JSON based grammar files. * Merge pull request Mudlet#102 from emoon/readme-fix * Merge branch 'Mudlet-master' (with some additions/changes) Signed-off-by: Stephen Lyons <[email protected]>
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Damn, this revision contains code that required at least Qt 5.14. (it uses |
…5.14 Signed-off-by: Stephen Lyons <[email protected]>
That last commit added:
|
We use a fork of edbee in https://github.com/Mudlet/edbee-lib because we had to make fixes to it previously, so that is what should be updated instead. Could you resubmit the PR there? |
Humm, this is not going to be as simple as I thought - I didn't realise that we were still using our own custom fork of this library... |
I will have to close this and start a fresh PR that cherry-picks all the commits in the upstream repository into our version... |
Closing in favour of |
Changelog:
Signed-off-by: Stephen Lyons [email protected]