fix: 🚑 Re-initialise BSPs' challenge cycle when changing stake

api-augment/dist/types/interfaces/augment-api-events.d.ts

@@ -2141,9 +2141,9 @@ declare module "@polkadot/api-base/types/events" {
        **/
       ProofAccepted: AugmentedEvent<
         ApiType,
-        [provider: H256, proof: PalletProofsDealerProof, lastTickProven: u32],
+        [providerId: H256, proof: PalletProofsDealerProof, lastTickProven: u32],
         {
-          provider: H256;
+          providerId: H256;
           proof: PalletProofsDealerProof;
           lastTickProven: u32;
         }

api-augment/dist/types/interfaces/augment-api-query.d.ts

@@ -54,6 +54,7 @@ import type {
   PalletPaymentStreamsDynamicRatePaymentStream,
   PalletPaymentStreamsFixedRatePaymentStream,
   PalletPaymentStreamsProviderLastChargeableInfo,
+  PalletProofsDealerProofSubmissionRecord,
   PalletStorageProvidersBackupStorageProvider,
   PalletStorageProvidersBucket,
   PalletStorageProvidersMainStorageProvider,
@@ -1380,23 +1381,6 @@ declare module "@polkadot/api-base/types/storage" {
        **/
       lastDeletedTick: AugmentedQuery<ApiType, () => Observable<u32>, []> &
         QueryableStorageEntry<ApiType, []>;
-      /**
-       * A mapping from a Provider to the last tick for which they SHOULD have submitted a proof.
-       * If for a Provider `p`, `LastTickProviderSubmittedAProofFor[p]` is `n`, then the
-       * Provider should submit a proof for tick `n + stake_to_challenge_period(p)`.
-       *
-       * This gets updated when a Provider submits a proof successfully and is used to determine the
-       * next tick for which the Provider should submit a proof, and it's deadline.
-       *
-       * If the Provider fails to submit a proof in time and is slashed, this will still get updated
-       * to the tick it should have submitted a proof for.
-       **/
-      lastTickProviderSubmittedAProofFor: AugmentedQuery<
-        ApiType,
-        (arg: H256 | string | Uint8Array) => Observable<Option<u32>>,
-        [H256]
-      > &
-        QueryableStorageEntry<ApiType, [H256]>;
       /**
        * The number of blocks that have been considered _not_ full in the last [`Config::BlockFullnessPeriod`].
        *
@@ -1434,6 +1418,27 @@ declare module "@polkadot/api-base/types/storage" {
         []
       > &
         QueryableStorageEntry<ApiType, []>;
+      /**
+       * A mapping from a Provider to its [`ProofSubmissionRecord`], which stores the last tick
+       * the Provider submitted a proof for, and the next tick the Provider should submit a proof for.
+       *
+       * Normally the difference between these two ticks is equal to the Provider's challenge period,
+       * but if the Provider's period is changed, this change only affects the next cycle. In other words,
+       * for one cycle, `next_tick_to_submit_proof_for - last_tick_proven ≠ provider_challenge_period`.
+       *
+       * If a Provider submits a proof successfully, both fields are updated.
+       *
+       * If the Provider fails to submit a proof in time and is slashed, only `next_tick_to_submit_proof_for`
+       * is updated.
+       **/
+      providerToProofSubmissionRecord: AugmentedQuery<
+        ApiType,
+        (
+          arg: H256 | string | Uint8Array
+        ) => Observable<Option<PalletProofsDealerProofSubmissionRecord>>,
+        [H256]
+      > &
+        QueryableStorageEntry<ApiType, [H256]>;
       slashableProviders: AugmentedQuery<
         ApiType,
         (arg: H256 | string | Uint8Array) => Observable<Option<u32>>,

api-augment/dist/types/interfaces/augment-api-runtime.d.ts

@@ -45,8 +45,8 @@ import type {
   GetChallengePeriodError,
   GetChallengeSeedError,
   GetCheckpointChallengesError,
-  GetLastTickProviderSubmittedProofError,
   GetNextDeadlineTickError,
+  GetProofSubmissionRecordError,
   GetUsersWithDebtOverThresholdError,
   IsStorageRequestOpenToVolunteersError,
   MainStorageProviderId,
@@ -488,7 +488,7 @@ declare module "@polkadot/api-base/types/calls" {
         ApiType,
         (
           providerId: ProviderId | string | Uint8Array
-        ) => Observable<Result<BlockNumber, GetLastTickProviderSubmittedProofError>>
+        ) => Observable<Result<BlockNumber, GetProofSubmissionRecordError>>
       >;
       /**
        * Get the next deadline tick.
@@ -499,6 +499,15 @@ declare module "@polkadot/api-base/types/calls" {
           providerId: ProviderId | string | Uint8Array
         ) => Observable<Result<BlockNumber, GetNextDeadlineTickError>>
       >;
+      /**
+       * Get the next tick for which the submitter should submit a proof.
+       **/
+      getNextTickToSubmitProofFor: AugmentedCall<
+        ApiType,
+        (
+          providerId: ProviderId | string | Uint8Array
+        ) => Observable<Result<BlockNumber, GetProofSubmissionRecordError>>
+      >;
       /**
        * Generic call
        **/

api-augment/dist/types/interfaces/augment-api-tx.d.ts

@@ -3327,19 +3327,23 @@ declare module "@polkadot/api-base/types/submittable" {
        * is provided, the proof submitter is considered to be the Provider.
        * Relies on a Providers pallet to get the root for the Provider.
        * Validates that the proof corresponds to a challenge that was made in the past,
-       * by checking the `TickToChallengesSeed` StorageMap. The challenge tick that the
-       * Provider should have submitted a proof is calculated based on the last tick they
-       * submitted a proof for ([`LastTickProviderSubmittedAProofFor`]), and the proving period for
-       * that Provider, which is a function of their stake.
+       * by checking the [`TickToChallengesSeed`] StorageMap. The challenge tick that the
+       * Provider should be submitting a proof for is retrieved from [`ProviderToProofSubmissionRecord`],
+       * and it was calculated based on the last tick they submitted a proof for, and the challenge
+       * period for that Provider, at the time of the previous proof submission or when it was
+       * marked as slashable.
+       *
        * This extrinsic also checks that there hasn't been a checkpoint challenge round
        * in between the last time the Provider submitted a proof for and the tick
        * for which the proof is being submitted. If there has been, the Provider is
-       * subject to slashing.
+       * expected to include responses to the checkpoint challenges in the proof.
        *
        * If valid:
        * - Pushes forward the Provider in the [`TickToProvidersDeadlines`] StorageMap a number
        * of ticks corresponding to the stake of the Provider.
-       * - Registers this tick as the last tick in which the Provider submitted a proof.
+       * - Registers the last tick for which the Provider submitted a proof for in
+       * [`ProviderToProofSubmissionRecord`], as well as the next tick for which the Provider
+       * should submit a proof for.
        *
        * Execution of this extrinsic should be refunded if the proof is valid.
        **/

api-augment/dist/types/interfaces/augment-types.d.ts

@@ -1265,8 +1265,8 @@ import type {
   GetChallengeSeedError,
   GetCheckpointChallengesError,
   GetFileFromFileStorageResult,
-  GetLastTickProviderSubmittedProofError,
   GetNextDeadlineTickError,
+  GetProofSubmissionRecordError,
   GetUsersWithDebtOverThresholdError,
   IncompleteFileStatus,
   IsStorageRequestOpenToVolunteersError,
@@ -1763,8 +1763,8 @@ declare module "@polkadot/types/types/registry" {
     GetChallengeSeedError: GetChallengeSeedError;
     GetCheckpointChallengesError: GetCheckpointChallengesError;
     GetFileFromFileStorageResult: GetFileFromFileStorageResult;
-    GetLastTickProviderSubmittedProofError: GetLastTickProviderSubmittedProofError;
     GetNextDeadlineTickError: GetNextDeadlineTickError;
+    GetProofSubmissionRecordError: GetProofSubmissionRecordError;
     GetUsersWithDebtOverThresholdError: GetUsersWithDebtOverThresholdError;
     GiltBid: GiltBid;
     GlobalValidationData: GlobalValidationData;