-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🚑 Re-initialise BSPs' challenge cycle when changing stake #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s after stake change
…ck for checkpoint challenges
…roofs Dealer pallet
…e updated after slashing
TDemeco
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
LastTickProviderSubmittedAProofFor
storage element in the Proofs Dealer pallet is replaced withProviderToProofSubmissionRecord
which holds a new structProofSubmissionRecord
, with both the last tick proven and the next to prove.proof_size
weight for thesubmit_proof
function, presumably because there is no more need to check a Provider's stake.checkpoint_tick
was equal tochallenge_tick_to_prove
, the Provider would have to submit proofs for the checkpoint challenges in that proof and also in the next one, wherelast_tick_proven
would be equal tocheckpoint_tick
. Consequently this was changed so that the checkpoint challenges are only required whencheckpoint_tick
is equal tochallenge_tick_to_prove
:checkpoint_tick == challenge_tick_to_prove
, while in the second submissioncheckpoint_tick == last_tick_proven
.get_next_tick_to_submit_proof_for
runtime API to fetch the next tick to prove for a given Provider. Now it's not necessarily the last tick proven + challenge priod.