Skip to content

fix: 🚑 Re-initialise BSPs' challenge cycle when changing stake #2371

fix: 🚑 Re-initialise BSPs' challenge cycle when changing stake

fix: 🚑 Re-initialise BSPs' challenge cycle when changing stake #2371

Triggered via pull request December 27, 2024 19:15
Status Success
Total duration 16m 28s
Artifacts

lint.yml

on: pull_request
Check format with rustfmt
38s
Check format with rustfmt
Check lint with clippy
16m 19s
Check lint with clippy
Check format with biome
12s
Check format with biome
Check lint with biome
14s
Check lint with biome
Typecheck with tsc
20s
Typecheck with tsc
Fit to window
Zoom out
Zoom in

Annotations

15 warnings
Check lint with biome
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Check format with biome
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Typecheck with tsc
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Check format with rustfmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Check lint with clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Check lint with clippy: pallets/randomness/src/benchmarking.rs#L6
bound is defined in more than one place
Check lint with clippy: pallets/randomness/src/lib.rs#L198
using `map_err` over `inspect_err`
Check lint with clippy: pallets/providers/src/lib.rs#L1455
using `map_err` over `inspect_err`
Check lint with clippy: pallets/proofs-dealer/src/lib.rs#L743
using `map_err` over `inspect_err`
Check lint with clippy: pallets/file-system/src/utils.rs#L70
the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable
Check lint with clippy: pallets/file-system/src/lib.rs#L1341
using `map_err` over `inspect_err`
Check lint with clippy: pallets/payment-streams/src/lib.rs#L413
using `map_err` over `inspect_err`
Check lint with clippy: pallets/bucket-nfts/src/lib.rs#L56
using `map_err` over `inspect_err`
Check lint with clippy: pallets/provider-randomness/src/lib.rs#L593
useless conversion to the same type: `std::collections::btree_set::Difference<'_, <<T as pallet_proofs_dealer::Config>::ProvidersPallet as shp_traits::ReadChallengeableProvidersInterface>::ProviderId>`
Check lint with clippy: pallets/provider-randomness/src/lib.rs#L643
called `expect` on `providers_to_mark` after checking its variant with `is_some`