PRODENG-2805 drop segment tokens #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
james-nesbitt
commented
Dec 3, 2024
james-nesbitt
commented
- token removed from code, can be injected at compile time
- if token is empty, disable analytics
- no need for dev/prod token separation, if it is getting injected
- also dropped superfluous logging for when analytics is disabled
james-nesbitt
force-pushed
the
PRODENG-2805-segment-token-remove
branch
2 times, most recently
from
63c5b05 to
4cdf7db
Compare
- token removed from code, can be injected at compile time - if token is empty, disable analytics - no need for dev/prod token separation, if it is getting injected Signed-off-by: James Nesbitt <[email protected]>
james-nesbitt
force-pushed
the
PRODENG-2805-segment-token-remove
branch
from
4cdf7db to
4b48a5d
Compare
|
I did manage to get the smoke test working locally. The GHA smoke test failure is just an issue with GH secrets since the repo went public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.