PRODENG-2805 drop segment tokens

- token removed from code, can be injected at compile time
- if token is empty, disable analytics
- no need for dev/prod token separation, if it is getting injected

Signed-off-by: James Nesbitt <[email protected]>

pkg/analytics/analytics.go

@@ -13,12 +13,8 @@ import (
 	analytics "gopkg.in/segmentio/analytics-go.v3"
 )
 
-const (
-	// ProdSegmentToken is the API token we use for Segment in production.
-	ProdSegmentToken = "FlDwKhRvN6ts7GMZEgoCEghffy9HXu8Z" //nolint:gosec // intentionally public
-	// DevSegmentToken is the API token we use for Segment in development.
-	DevSegmentToken = "DLJn53HXEhUHZ4fPO45MMUhvbHRcfkLE" //nolint:gosec // intentionally public
-)
+// SegmentToken is the API token we use for Segment. Set at compile time.
+var SegmentToken = ""
 
 // Analytics is the interface used for our analytics client.
 type Analytics interface {
@@ -36,11 +32,12 @@ type Client struct {
 var defaultClient Client
 
 func init() {
-	segmentToken := DevSegmentToken
-	if version.IsProduction() {
-		segmentToken = ProdSegmentToken
+	if SegmentToken == "" {
+		defaultClient = Client{IsEnabled: false}
+		return
 	}
-	ac, err := NewSegmentClient(segmentToken)
+
+	ac, err := NewSegmentClient(SegmentToken)
 	if err != nil {
 		log.Warnf("failed to initialize analytics: %v", err)
 		return
@@ -68,7 +65,6 @@ func NewSegmentClient(segmentToken string) (Analytics, error) { //nolint:ireturn
 // is enabled.
 func (c *Client) TrackEvent(event string, properties analytics.Properties) error {
 	if !c.IsEnabled {
-		log.Debugf("analytics disabled, not tracking event '%s'", event)
 		return nil
 	}
 
@@ -95,7 +91,6 @@ func (c *Client) TrackEvent(event string, properties analytics.Properties) error
 // is enabled.
 func (c *Client) IdentifyUser(userConfig *user.Config) error {
 	if !c.IsEnabled {
-		log.Debug("analytics disabled, not identifying user")
 		return nil
 	}
 	msg := analytics.Identify{

pkg/analytics/analytics_test.go

@@ -83,6 +83,9 @@ func TestIdentifyAnalyticsUser(t *testing.T) {
 }
 
 func TestDefaultClient(t *testing.T) {
+	sc, _ := NewSegmentClient("AAAAAAAAA")
+	defaultClient.AnalyticsClient = sc
+
 	userConfig := user.Config{
 		Name:    "John Doe",
 		Email:   "[email protected]",
@@ -102,6 +105,7 @@ func TestDefaultClient(t *testing.T) {
 	t.Run("Analytics enabled", func(t *testing.T) {
 		old := defaultClient.IsEnabled
 		Enabled(true)
+
 		defer Enabled(old)
 
 		TrackEvent("foobar", nil)