Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRODENG-2527 Added make install target to the Makefile #419

Closed
wants to merge 1 commit into from
Closed

PRODENG-2527 Added make install target to the Makefile #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ build-all: builder
GOOS=darwin GOARCH=amd64 $(GO) go build $(BUILD_FLAGS) -o bin/launchpad-darwin-x64 main.go
GOOS=darwin GOARCH=arm64 $(GO) go build $(BUILD_FLAGS) -o bin/launchpad-darwin-arm64 main.go

install: build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
install: build
install: launchpad

sudo install -m 755 bin/launchpad /usr/local/bin/launchpad
Copy link
Collaborator

@kke kke Feb 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is some kind of convention to have this as:

	install -d $(DESTDIR)$(PREFIX)/bin/
	install -m 755 launchpad $(DESTDIR)$(PREFIX)/bin/

and have this somewhere in the top:

PREFIX = /usr/local

This way `make install PREFIX=/some/package/manager/library" will work correctly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it shouldn't sudo on its own, user should use sudo make install.


go-mod-tidy: builder
$(GO) go mod tidy

Expand Down