PRODENG-2527 Added make install target to the Makefile #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dimitrov <[email protected]>
kke
reviewed
Feb 8, 2024
| @@ -53,6 +53,9 @@ build-all: builder | |||
| GOOS=darwin GOARCH=amd64 $(GO) go build $(BUILD_FLAGS) -o bin/launchpad-darwin-x64 main.go | |||
| GOOS=darwin GOARCH=arm64 $(GO) go build $(BUILD_FLAGS) -o bin/launchpad-darwin-arm64 main.go | |||
|
|
|||
| install: build | |||
| sudo install -m 755 bin/launchpad /usr/local/bin/launchpad | |||
There was a problem hiding this comment.
It is some kind of convention to have this as:
install -d $(DESTDIR)$(PREFIX)/bin/
install -m 755 launchpad $(DESTDIR)$(PREFIX)/bin/and have this somewhere in the top:
PREFIX = /usr/localThis way `make install PREFIX=/some/package/manager/library" will work correctly.
There was a problem hiding this comment.
Also it shouldn't sudo on its own, user should use sudo make install.
kke
reviewed
Feb 8, 2024
| @@ -53,6 +53,9 @@ build-all: builder | |||
| GOOS=darwin GOARCH=amd64 $(GO) go build $(BUILD_FLAGS) -o bin/launchpad-darwin-x64 main.go | |||
| GOOS=darwin GOARCH=arm64 $(GO) go build $(BUILD_FLAGS) -o bin/launchpad-darwin-arm64 main.go | |||
|
|
|||
| install: build | |||
There was a problem hiding this comment.
Suggested change
| install: build | |
| install: launchpad |
|
This is likely abandonded. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make installwhich install the binary under the local bin folderhttps://mirantis.jira.com/browse/PRODENG-2527