[BOP-56] Run CI on merge to main #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwneisen
commented
Nov 3, 2023
| workflow_call: | ||
|
|
||
| jobs: | ||
| # push-latest: |
There was a problem hiding this comment.
I'll uncomment and clean this up when I do the release CI PR
nwneisen
commented
Nov 3, 2023
.github/workflows/push-to-ghcr.yml
Outdated
| # working-directory: . | ||
| # run: make docker-push | ||
|
|
||
| push-dev: |
There was a problem hiding this comment.
There is a lot of repeated steps here but doing it this way keeps each of the push jobs independent. The repeated sections are also very quick and don't take long to run.
nwneisen
commented
Nov 3, 2023
nwneisen
commented
Nov 3, 2023
| @@ -0,0 +1,74 @@ | |||
| name: Push docker images | |||
There was a problem hiding this comment.
This was release.yml. I'll be creating another release.yml file that reuses this code
Merged
tppolkow
reviewed
Nov 3, 2023
tppolkow
approved these changes
Nov 3, 2023
ranyodh
requested changes
Nov 3, 2023
ranyodh
reviewed
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mirantis.jira.com/browse/BOP-56
What this PR does
Adds a CI to run when we merge a PR into main
I set this up to only push an image with the commit SHA. This way dev images are still available in our current registry but anyone using latest wont run into issues. I'll cleanup the release push steps in the followup release CI PR.
Testing
I tested this on my fork of the repo. The push stage didn't work due to credentials but this step was previously working and so I wasn't worried about it.