[BOP-55] CI for releases #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwneisen
commented
Nov 3, 2023
ranyodh
requested changes
Nov 3, 2023
ranyodh
reviewed
Nov 6, 2023
|
|
||
| on: | ||
| release: | ||
| types: [prereleased] |
There was a problem hiding this comment.
@nwneisen Can we also run this workflow when a "Release" is created. Or is there a reason for using running it when a pre-release is created?
There was a problem hiding this comment.
It can also be run for published instead.
I use prerelease so that everything can be created and checked before it officially went out. It's just a last check for any small mistakes that stop the need for following up with a small fix release or if any automations run and try to pull the release artifacts before they are created.
There was a problem hiding this comment.
Same idea as what someone might use a draft release for except GHA has no support for draft releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mirantis.jira.com/browse/BOP-55
What this PR does
Adds a CI for the release process that triggers when a release is created on the github page
Testing
Tested this on my fork of the repo. Made sure the push commands had the correct tags but failed as expected due to my fork on having credentials to the registry
Notes
This is based off of #8. There is a lot of duplicate code from the PR. It should be reviewed first and then I will rebase this PR.